Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip permissions update if not needed #371

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Apr 22, 2022

When creating (or updating) the compass environment, it is not necessary to check or change permissions unless we are modifying the shared conda or spack environments. This merge removes unnecessary attempts to change permissions.

When creating (or updating) the compass environment, it is not
necessary to check or change permissions unless we are modifying
the shared conda or spack environments.  This merge removes
unnecessary attempts to change permissions.
@xylar xylar added clean-up dependencies and deployment Changes relate to creating conda and Spack environments, and creating a load script labels Apr 22, 2022
@xylar xylar self-assigned this Apr 22, 2022
@xylar
Copy link
Collaborator Author

xylar commented Apr 22, 2022

Testing

I updated the compass environment. First, I ran without --update_spack and saw no permission updates. Then, I ran with --update_spack and saw the expected permission updates.

@xylar xylar merged commit 7d39b46 into MPAS-Dev:master Apr 22, 2022
@xylar xylar deleted the remove_unneeded_permissions_update branch April 22, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean-up dependencies and deployment Changes relate to creating conda and Spack environments, and creating a load script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant