Create basic config for an MPAS core #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for both provenance and test cases, and will also be needed for job scripts.
TestingI ran the ocean This commit has also been tested as part of the testing I did for #376 |
|
@matthewhoffman, please give this a quick look when you have a chance. |
|
@matthewhoffman, I'm going to go ahead with this one so as not to distract from #376 and to not overwhelm you (any more than I have to at least) with reviews. |
|
Ok, thanks! I glanced at it last night and had no concerns to the extent I followed the details. I went hunting for it now and found it already merged, which was nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for both provenance and test cases, and will also be needed for job scripts.
For provenance, it is necessary to have config options that come from most sources (defaults, mache, machine-specific, MPAS-core and user) but where a test group and test case has not yet been determined so those are not included.
Previously, the framework redundantly made new "basic" config options as a starting point for each test case, adding more config options for the test group and test case, and to call the test case's
configure()method.That code was duplicated because it initially seemed trivial but slowly got more complex. For #376, I needed this "basic" set of config options in a 3rd place (for making job scrips) and it was clearly time to fix the unnecessary duplicate code.