Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused tag #217

Closed
wants to merge 1 commit into from

Conversation

alexolinhager
Copy link
Contributor

Removes bug in geometric_features/features_and_tags.json, in which an unused region was listed. northGreenland4_oceanExtended was absorbed by its neighboring regions when extending into ocean, so should no longer be listed in this file.

@xylar
Copy link
Collaborator

xylar commented Dec 20, 2024

Indeed, it is obvious that this feature no longer exists:
https://github.com/MPAS-Dev/geometric_features/tree/main/geometric_data/landice/region
Presumably, we should also have a sanity check to make sure all the features in the json file actually exist. I'll make a separate PR for that.

@xylar
Copy link
Collaborator

xylar commented Dec 20, 2024

As mentioned in #218, #219 and #220, I think there are more things that need to be fixed. I think it might make sense to close this PR and let #220 take care of this fix along with several others.

@xylar xylar self-requested a review December 20, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants