add medoid method for calculation of cluster center #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6 +/- ##
=======================================
Coverage ? 30.00%
=======================================
Files ? 4
Lines ? 170
Branches ? 0
=======================================
Hits ? 51
Misses ? 119
Partials ? 0 ☔ View full report in Codecov by Sentry. |
|
Alright, merged. It works :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already knew that calculating the arithmetic average of all embeddings belonging to one clusters isn't ideal. Now, we are calculating the medoid instead of the arithmetic average. We expect that the medoid should be much less sensitive on outliers, plus the medoid is always on the surface of the hyper sphere.
scipy.cdist is actually quite fast. In case of more then 50k samples per cluster we take a random sample of 50k and calculate the medoid based on the sub-sample
Needs some checks by @GavinR1 ...