Failure when executing SQL string

[hcusto]

I'm trying to use ReliableDbProvider with EF 5. and I'm unable to execute hand written sql query. Here is failing test

public void Insert_and_select_entity()
    {
        using (var context = GetContext())
        using (var context2 = GetContext())
        {
            var user = new User { Name = "Name" };
            context.Users.Add(user);
            context.SaveChanges();

            var dbUser = context2.Database.SqlQuery<User>("select * from users where Id = '" + user.Id + "'").FirstOrDefault();

            Assert.That(dbUser.Name, Is.EqualTo(user.Name));
        }
    }

here is part that breaks Test

var dbUser = context2.Database.SqlQuery<User>("select * from users where Id = '" + user.Id + "'").FirstOrDefault();

Error is inside ReliableSqlCommand

  protected override DbDataReader ExecuteDbDataReader(CommandBehavior behavior)
        {
          //ReliableConnection is null
            return ReliableConnection.CommandRetryPolicy.ExecuteAction(() => {
                if (Connection == null)
                    Connection = ReliableConnection.Open();
                if (Connection.State != ConnectionState.Open)
                    Connection.Open();
                return Current.ExecuteReader(behavior);
            });
        } 

[robdmoore]

Hey mate,

I didn't get a chance to look at this over the weekend - was busy repaving my machine.

Will try and look sometime this week.

[hcusto]

Hi Rob, thanks for heads up.

[robdmoore]

Hey,

I've started taking a look at this. I've got a WIP pull request up with failing tests - I can confirm this is a problem.

Off the top of my head I don't know why it's not using the reliable connection - it seems to be bypassing the proxy code somehow. This stuff is super, super complex and it's been quite a while since I've had my head into it so to be honest it might take me a while to figure it out.

cc @MattDavies

[BlairAllegroTech]

The reason for this code failing was that the "ReliableConnection" of the Command was not being set in the constructor when the ReliableSqlDbComand was being constructed with a command that already has an associated Connection. To overcome this issue i have added a second constructor that take as SQLCommand and a ReliableSqlDbConnection (Which is just the wrapped version of the existing commands connection.

    //Bug Fix: Failure when executing SQL string
    public ReliableSqlCommand(ReliableSqlDbConnection connection, SqlCommand commandToWrap) 
    {
        this.Current = commandToWrap;
        this.ReliableDbConnection = connection;
        this.ReliableConnection = (connection==null) ? null : connection.ReliableConnection;
    } 

[robdmoore]

Awesome! Thanks for finding the problem :)

I'll take a look over the next week and get the code in!

[robdmoore]

@hcusto this problem should be fixed in the next version of ReliableDbProvider. I'll let you know when it's released.