Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test for issue #2. #3

Closed
wants to merge 3 commits into from

Conversation

mikoskinen
Copy link
Contributor

Here's a test which shows the issue #2.

@robdmoore
Copy link
Member

Good start :). I was probably more thinking of having an integration test that used the db provider in the same way as massive does so we can see that it still works when I make the change (e.g. get the command from the provider, set the connection (assuming that's what massive does), set the command text, invoke the command, etc.).

Again, if you don't have the time I'm happy to do it when I get around to it (just preparing for a user group presentation I'm giving next week so might be a few days though).

@mikoskinen
Copy link
Contributor Author

Ah, ok. One option is to include Massive in the test project (it's only one .CS file) and to write a test which tries to use it. That shouldn't take too long, if it's ok with you?

@robdmoore
Copy link
Member

Fine by me - the other tests use Entity Framework to check it works so really its the same kind of thing.

@mikoskinen
Copy link
Contributor Author

It's not possible to create the database (or tables) through Massive so I'm using the EF to create the User and UserProperty-tables. It's not very pretty.

@robdmoore
Copy link
Member

The tables are created by migrations not by EF so I wouldn't expect you to create them using Massive :)

@robdmoore
Copy link
Member

Actually, you are completely right sorry - my bad; I was getting confused between this project and the NHibernate one (that has similar code and tests, but uses migrations).

@robdmoore robdmoore closed this in efeb8db Jul 17, 2013
@robdmoore
Copy link
Member

I was too eager (and I'm procrastinating for preparing for my talk :P don't tell @jtabadero).

I've fixed the problem and Entity Framework still works according to the tests so I'll push out a nuget as soon as the CI server builds it :)

Thanks again for raising this!

@robdmoore
Copy link
Member

https://nuget.org/packages/ReliableDbProvider 0.9.7 released

@mikoskinen
Copy link
Contributor Author

Excellent, thank you! :)

I have to say that this project is really a life saver for me as it works with the Universal Membership Providers too. No more wrapping code in some retry policies!

@robdmoore
Copy link
Member

Awesome! Great to hear :)

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants