Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FetchContent to download NIfTI headers #3004

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Use FetchContent to download NIfTI headers #3004

merged 2 commits into from
Sep 20, 2024

Conversation

daljit46
Copy link
Member

This allows the headers to be downloaded at configure time so they're unconditionally available to all targets at build time.
Closes #3002

@daljit46 daljit46 self-assigned this Sep 17, 2024
Copy link

clang-tidy review says "All clean, LGTM! 👍"

@daljit46 daljit46 marked this pull request as draft September 18, 2024 07:33
Copy link

clang-tidy review says "All clean, LGTM! 👍"

2 similar comments
Copy link

clang-tidy review says "All clean, LGTM! 👍"

Copy link

clang-tidy review says "All clean, LGTM! 👍"

This allows the headers to be downloaded at configure time so they're unconditionally
available to all targets at build time.
Copy link

clang-tidy review says "All clean, LGTM! 👍"

@daljit46 daljit46 marked this pull request as ready for review September 18, 2024 08:49
@daljit46 daljit46 merged commit e5860df into dev Sep 20, 2024
6 checks passed
@daljit46 daljit46 deleted the nifti_fetchcontent branch September 20, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant