Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block reference are shown in presentation #125

Closed
SylvainGuieu opened this issue Aug 26, 2022 · 3 comments
Closed

Block reference are shown in presentation #125

SylvainGuieu opened this issue Aug 26, 2022 · 3 comments

Comments

@SylvainGuieu
Copy link

Not a big deal, for the record, block references appear in slides.

Block of  Text
^refblock

image

Found when trying to embed a note (containing block references).
Cheers.

@SylvainGuieu
Copy link
Author

SylvainGuieu commented Aug 26, 2022

Also I encountered a problem when referencing a code block, the closing "```" are missing.

e.g. :

Somewhere:


```pyhton
for i in range(10):
	print(i)
\```
^codeexemple

somewhere else:


![[slide tutorial#^codeexemple]]

Problem

image

Looking at html :

       <div class="slides"><section  data-markdown><script type="text/template">
```pyhton
for i in range(10):
	print(i)



Problem

</script></section></div>

Hope this helps.

@SylvainGuieu
Copy link
Author

For the problem #2 :

Adding +1 to presolved.end.line solve this specific problem. Do not know if they are side effects.

	if (resolved && resolved.start && resolved.start.line != null) {
		if (resolved.end && resolved.end.line != null) {
			return this.substring(fileContent, resolved.start.line, resolved.start.col, resolved.end.line+1, resolved.end.col);
		} else {
			return this.substring(fileContent, resolved.start.line, resolved.start.col, -1, -1);
		}

	} else {
		return '![[' + relativeFilePath + '#' + header + ']]';
	}

@MSzturc
Copy link
Owner

MSzturc commented Aug 26, 2022

will be fixed in next version

@MSzturc MSzturc closed this as completed Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants