Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ctf_chat: Replace the sender-side response for /msg #1048

Merged
merged 5 commits into from
Aug 28, 2022
Merged

ctf_chat: Replace the sender-side response for /msg #1048

merged 5 commits into from
Aug 28, 2022

Conversation

Vagankovo
Copy link
Contributor

@Vagankovo Vagankovo commented Aug 25, 2022 •
edited
Loading

Currently when you send a private message, you get a nondescript Message sent., which makes it harder to talk. The changes will make /msg give out To <RECEPIENT>: <MESSAGE> instead.

@Vagankovo Vagankovo changed the title Replace the sender-side response for /msg ctf_chat: Replace the sender-side response for /msg Aug 25, 2022
magnetar47
magnetar47 requested changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@magnetar47 magnetar47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this change is worth it, but since you've made a PR yourself, then why not.

mods/ctf/ctf_chat/init.lua Outdated Show resolved Hide resolved
@LoneWolfHT LoneWolfHT merged commit 362a416 into MT-CTF:master Aug 28, 2022
@Vagankovo Vagankovo deleted the messagetinker branch August 28, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magnetar47 magnetar47 magnetar47 requested changes

@LoneWolfHT LoneWolfHT LoneWolfHT approved these changes

Assignees
No one assigned
Labels
Action / change needed ❗ ⚙️ Chat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vagankovo @LoneWolfHT @magnetar47