Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing definition of pro #1122

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

changing definition of pro #1122

wants to merge 2 commits into from

Conversation

farooqkz
Copy link
Contributor

This PR changes definition of a pro player to one who has at least 8000 score and at least one of these requirements:

  • K/D is at least 1.4(each kill assist counts as 1/3 kill)
  • H/D is at least 30(30 hp healed for every one death)
  • C/D is at least 1/14(one capture for every 14 deaths)

@xenonca
Copy link
Contributor

xenonca commented Mar 23, 2023

I feel like this is something that needs discussion first before being merged, maybe even a poll on Discord.

@LoneWolfHT
Copy link
Member

Yeah, there'll be a series of polls probably

@farooqkz
Copy link
Contributor Author

Ah okay I'm not on Discord. Let me know if poll succeeded or failed :)

@tigercoding56
Copy link

no noone gets 8000 score casually in a match
and K/D , well that is just discouraging anyone to take to much of a risk

@farooqkz
Copy link
Contributor Author

That's the point. You need play several matches to become a pro. That will also prevent meaningless results. However, 8k might be a little too much.

@farooqkz
Copy link
Contributor Author

farooqkz commented Apr 3, 2023

@LoneWolfHT What was result of the poll?

@LoneWolfHT
Copy link
Member

LoneWolfHT commented Apr 3, 2023

@LoneWolfHT What was result of the poll?

I have yet to do any polls, I'm setting up something more accessible

@farooqkz
Copy link
Contributor Author

farooqkz commented Apr 4, 2023

@LoneWolfHT What was result of the poll?

I have yet to do any polls, I'm setting up something more accessible

Like an in game poll?

@farooqkz
Copy link
Contributor Author

@LoneWolfHT bump

@farooqkz farooqkz added the 📝Needs Poll A poll needs to be run to decide on implementation label Jun 12, 2023
@LoneWolfHT
Copy link
Member

LoneWolfHT commented Jun 29, 2023

The process on making one has started, ETA is 2023

@farooqkz
Copy link
Contributor Author

The process on making one has started, ETA is 2023

What do you mean by "ETA is 2023"? Like you want to wait till the end of 2023 for decision about this?

@LoneWolfHT
Copy link
Member

What do you mean by "ETA is 2023"? Like you want to wait till the end of 2023 for decision about this?

It will happen in 2023, I was anticipating you asking me for an exact date

@farooqkz
Copy link
Contributor Author

What do you mean by "ETA is 2023"? Like you want to wait till the end of 2023 for decision about this?

It will happen in 2023, I was anticipating you asking me for an exact date

Aren't we already in 2023?

@Infernia829
Copy link
Contributor

Yep, he means that it will be done this year, and won't be dragged into next year.

@mrtechtroid
Copy link
Contributor

Hi there, while we are at it, why not change add a pro role/privilage additionally? Instead of replacing/modifying existing player data, this role will over-ride all score/attempt/heals/etc. and if a player has this role, he can access a pro chest.

@farooqkz
Copy link
Contributor Author

farooqkz commented Jul 1, 2024

Hi there, while we are at it, why not change add a pro role/privilage additionally? Instead of replacing/modifying existing player data, this role will over-ride all score/attempt/heals/etc. and if a player has this role, he can access a pro chest.

I don't get. And then we'll have to add this role to player manually? The admin already can make players pro manually. This isn't the point.

@mrtechtroid
Copy link
Contributor

No what I meant is for a way to allow players to be marked as pro without relying/modifying their game stats. Like you can manually if wanted to assign pro to a player who has 0 score. ( Rationale for this addition is for testing purposes and for extreme case scenarios)

@LoneWolfHT LoneWolfHT added the 🏗️ Ranked Reset Queue Can only be merged after the next ranking reset label Jul 11, 2024
@AnonomousAccount
Copy link
Contributor

The problem with comparing all these stats to deaths, means it award campers, and people who take less risks. It also makes some people always think about their stats, and not have as much fun actually playing the game

@LoneWolfHT
Copy link
Member

The problem with comparing all these stats to deaths, means it award campers, and people who take less risks. It also makes some people always think about their stats, and not have as much fun actually playing the game

For the former part that helps with making sure stuff in the pro chest gets used well

@mazes-80
Copy link

That's of real interest for me.

I already thought about one other metric to gain pro access via captures.
points / captures <= 500 and capture success / captures attempts > 1/3

Maybe death / capture is better because points highly depend on round length and success / attempts is already quite included in (fail quite always mean death)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature ⭐ ⚙️ Scoring Medium Priority 📝Needs Poll A poll needs to be run to decide on implementation Proposal/Suggestion 🏗️ Ranked Reset Queue Can only be merged after the next ranking reset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants