give score for items removed from enemies

[farooqkz]

This PR gives score to the players if they put an item dropped from teammate or enemy and put it in the teamchest. The item must not be stackable.

[AltZ-15]

What stops players from just cashing in all the items they've collected and talking it all back from the chest as soon as they get the points?

[farooqkz]

What stops players from just cashing in all the items they've collected and talking it all back from the chest as soon as they get the points?

It's a reasonable concern. But why they would do that?

[LoneWolfHT]

You could replace the meta string "dropped" with an int value. meta:get_int() returns 0 for unset values, and you could treat 1 as truthy
meta:set_int("dropped", 1), etc

[LoneWolfHT]

To play it safe I would prefer to only give 1 or less score for items we reward returning, and slowly increase that as we watch things play out on the main server

[farooqkz]

To play it safe I would prefer to only give 1 or less score for items we reward returning, and slowly increase that as we watch things play out on the main server

I disagree with the reward being the same, one point, for all the items. And less than one is a bad idea IMO

[LoneWolfHT]

I disagree with the reward being the same, one point, for all the items. And less than one is a bad idea IMO

Did you read the and slowly increase that as we watch things play out on the main server part? The item values can be differentiated again as we increase them

[farooqkz]

I disagree with the reward being the same, one point, for all the items. And less than one is a bad idea IMO

Did you read the and slowly increase that as we watch things play out on the main server part? The item values can be differentiated again as we increase them

Yeah I know but it doesn't make sense to me even temporary. But if you mean some stuff can be temporary non-sensible, that's your decision. I am committing to give exactly one for all items.

[LoneWolfHT]

Thanks.
#1173 (comment) needs to be fixed and this will be ready for testing

[LoneWolfHT]

Your rebase didn't work at all there

[LoneWolfHT]

With rebasing I tend to use git rebase -i <PR branch>~<number of previous commits I want to have the option to squash> (e.g git rebase -i master~6), squash all my commits together, then git pull -r mainrepo master to rebase off of the CTF repo's master branch

I'm laying that out to show you some things you can do, I highly recommend googling/figuring out what those commands do on your own though, you can seriously mess things up otherwise

[LoneWolfHT]

Items returned to team chest shouldn't give score if they're your own

[farooqkz]

@LoneWolfHT Done.

[LoneWolfHT]

Rebase conflict

[farooqkz]

Rebase conflict

WDYM?

[LoneWolfHT]

[farooqkz]

@LoneWolfHT Done

[LoneWolfHT]

How are you rebasing your PR? This shouldn't be showing up:

[farooqkz]

@LoneWolfHT What was state of this? Do I need to do anything?