Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French translations and support #1325

Merged
merged 5 commits into from
Jul 12, 2024
Merged

French translations and support #1325

merged 5 commits into from
Jul 12, 2024

Conversation

ClementMR
Copy link
Contributor

@ClementMR ClementMR commented Jul 12, 2024

  • This PR has been tested locally

Add french translations

@LoneWolfHT
Copy link
Member

Thanks for the PR, won't this break all the other translations though?

@ClementMR
Copy link
Contributor Author

Translations using the old method did not work, but now they are effective

@LoneWolfHT LoneWolfHT merged commit e08e877 into MT-CTF:master Jul 12, 2024
1 check passed
Copy link
Contributor Author

@ClementMR ClementMR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I lately did something wrong

S("and looking at your feet."),
S("Use /map to print the current map name and its author."),
S("To check someone's ranking in all modes, use /rank mode:all <player_name>"),
S("Building a base with materials stronger than cobblestone, such as wood or reinforced cobble, " ..
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
S("Building a base with materials stronger than cobblestone, such as wood or reinforced cobble, " ..
S("Building a base with materials stronger than cobblestone, such as wood or reinforced cobble, keeps your flag safer."),

S("Use /map to print the current map name and its author."),
S("To check someone's ranking in all modes, use /rank mode:all <player_name>"),
S("Building a base with materials stronger than cobblestone, such as wood or reinforced cobble, " ..
"keeps your flag safer."),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"keeps your flag safer."),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants