-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ajoute et execute l'outil d'import des aires de stockage #1166
Merged
+569
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
florimondmanca
force-pushed
the
feat/storageAreaModel
branch
from
January 27, 2025 15:03
ff6a60b
to
be0c48a
Compare
florimondmanca
force-pushed
the
feat/storageAreaModel
branch
from
January 27, 2025 15:37
be0c48a
to
a0bd5fb
Compare
florimondmanca
force-pushed
the
feat/storage-area-import
branch
4 times, most recently
from
January 28, 2025 11:29
ede1613
to
7df5610
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1166 +/- ##
============================================
- Coverage 98.95% 98.93% -0.02%
- Complexity 1930 1946 +16
============================================
Files 388 390 +2
Lines 8292 8390 +98
============================================
+ Hits 8205 8301 +96
- Misses 87 89 +2 ☔ View full report in Codecov by Sentry. |
florimondmanca
force-pushed
the
feat/storageAreaModel
branch
from
January 28, 2025 11:39
a0bd5fb
to
927be14
Compare
florimondmanca
force-pushed
the
feat/storage-area-import
branch
from
January 28, 2025 11:41
7df5610
to
840919a
Compare
florimondmanca
changed the title
Ajoute la commande app:storage_area_generate
Ajoute et execute l'outil d'import des aires de stockage
Jan 28, 2025
florimondmanca
force-pushed
the
feat/storage-area-import
branch
from
January 28, 2025 11:46
840919a
to
14e26e3
Compare
florimondmanca
force-pushed
the
feat/storage-area-import
branch
from
January 28, 2025 15:34
d89006b
to
11095bc
Compare
florimondmanca
force-pushed
the
feat/storage-area-import
branch
from
January 28, 2025 15:37
11095bc
to
cbdd9f0
Compare
mmarchois
reviewed
Jan 29, 2025
florimondmanca
force-pushed
the
feat/storage-area-import
branch
from
January 30, 2025 10:17
1fe7092
to
9ee0ea2
Compare
@mmarchois Retours traités, pratique le SerializerComponent :) (il n'était pas encore installé par nous donc je l'ai require) |
mmarchois
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cette PR implémente un outil qui permet de parser le CSV des aires de stockage pour générer une ligne de PHP à insérer dans une migration. Cette ligne contient le SQL pour insérer les aires de stockage dans la table
storage_area
.J'ai ensuite exécuté l'outil sur le CSV fourni par @MathieuFV ce qui a donné la migration présente dans cette PR.
=> On pourra facilement de mettre à jour les aires de stockage plus tard (je l'ai documenté dans
docs/storage_areas.md
), donc je préfère proposer cette PR en l'état pour pouvoir avancer ensuite sur l'UI.