Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajoute et execute l'outil d'import des aires de stockage #1166

Merged
merged 8 commits into from
Jan 30, 2025

Conversation

florimondmanca
Copy link
Collaborator

@florimondmanca florimondmanca commented Jan 23, 2025

Description

Cette PR implémente un outil qui permet de parser le CSV des aires de stockage pour générer une ligne de PHP à insérer dans une migration. Cette ligne contient le SQL pour insérer les aires de stockage dans la table storage_area.

J'ai ensuite exécuté l'outil sur le CSV fourni par @MathieuFV ce qui a donné la migration présente dans cette PR.

⚠️ Pour environ la moitié des aires de stockage fournies, notre algo de géocodage de section de nationale n'aboutit pas : je pense que c'est à cause de #713.

=> On pourra facilement de mettre à jour les aires de stockage plus tard (je l'ai documenté dans docs/storage_areas.md), donc je préfère proposer cette PR en l'état pour pouvoir avancer ensuite sur l'UI.

@florimondmanca florimondmanca force-pushed the feat/storage-area-import branch 4 times, most recently from ede1613 to 7df5610 Compare January 28, 2025 11:29
@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 97.95918% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.93%. Comparing base (21edf9b) to head (9ee0ea2).

Files with missing lines Patch % Lines
...Data/StorageArea/StorageAreaMigrationGenerator.php 97.70% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1166      +/-   ##
============================================
- Coverage     98.95%   98.93%   -0.02%     
- Complexity     1930     1946      +16     
============================================
  Files           388      390       +2     
  Lines          8292     8390      +98     
============================================
+ Hits           8205     8301      +96     
- Misses           87       89       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@florimondmanca florimondmanca force-pushed the feat/storage-area-import branch from 7df5610 to 840919a Compare January 28, 2025 11:41
@florimondmanca florimondmanca changed the title Ajoute la commande app:storage_area_generate Ajoute et execute l'outil d'import des aires de stockage Jan 28, 2025
@florimondmanca florimondmanca force-pushed the feat/storage-area-import branch from 840919a to 14e26e3 Compare January 28, 2025 11:46
Base automatically changed from feat/storageAreaModel to main January 28, 2025 14:01
@florimondmanca florimondmanca marked this pull request as ready for review January 28, 2025 15:29
@florimondmanca florimondmanca force-pushed the feat/storage-area-import branch from d89006b to 11095bc Compare January 28, 2025 15:34
@florimondmanca florimondmanca force-pushed the feat/storage-area-import branch from 11095bc to cbdd9f0 Compare January 28, 2025 15:37
@florimondmanca florimondmanca force-pushed the feat/storage-area-import branch from 1fe7092 to 9ee0ea2 Compare January 30, 2025 10:17
@florimondmanca
Copy link
Collaborator Author

@mmarchois Retours traités, pratique le SerializerComponent :) (il n'était pas encore installé par nous donc je l'ai require)

@florimondmanca florimondmanca merged commit 48435fe into main Jan 30, 2025
5 checks passed
@florimondmanca florimondmanca deleted the feat/storage-area-import branch January 30, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants