Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a loading spinner to Food PoC page. #150

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Conversation

n1k0
Copy link
Member

@n1k0 n1k0 commented Aug 22, 2022

We can't track JSON db download progress because elm-http doesn't allow tracking with task based requests, so neither does remotedata-http.

So we're left with just a rolling spinner materializing the (long) loading stage, which is still better than nothing.

@n1k0 n1k0 requested a review from magopian August 22, 2022 13:23
Copy link
Contributor

@magopian magopian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

impressive work ;)

@magopian
Copy link
Contributor

All jokes aside, thanks a lot for investigating that, sad that we can't have nice things in our case, but that's the way it is.

@n1k0 n1k0 merged commit 7463b23 into master Aug 22, 2022
@n1k0 n1k0 deleted the food-db-loading-spinner branch August 22, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants