[TRA 15687] Ajout d'éco-organismes, filtrage des éco-organismes en front #3916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riron
approved these changes
Jan 17, 2025
GaelFerrand
reviewed
Jan 21, 2025
| handleBsdd: handleBsdd ?? undefined, | ||
| handleBsda: handleBsda ?? undefined, | ||
| handleBsdasri: handleBsdasri ?? undefined, | ||
| handleBsvhu: handleBsvhu ?? undefined |
There was a problem hiding this comment.
Je comprends pas ce morceau, handleXXX ne peut pas être undefined en base, donc pourquoi ?? undefined?
There was a problem hiding this comment.
L'input de la query peut être true/false ou null, mais si on passe null, ça revient à demander les éco-organismes où la valeure est nulle (ce qui n'est normalement jamais le cas), donc on remplace null par undefined, ce qui revient à ne pas filtrer par ce paramètre
GaelFerrand
reviewed
Jan 21, 2025
| @@ -11,11 +11,220 @@ type CreationObject<M extends keyof PrismaClient> = { | |||
| }; | |||
| const objects = [ | |||
There was a problem hiding this comment.
C'est utilisé où ça du coup?
There was a problem hiding this comment.
dans object-creator/main, qui est appelé en tant que script
GaelFerrand
approved these changes
Jan 21, 2025
…sing ecoorganismes, add params to the ecoOrganisme query, use the params in the various EcoOrganism components
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contexte
Il fallait:
J'ai donc ajouté les éco-organismes manquants au script d'ajout d'objet, à faire tourner dans une one-off (
npx nx run object-creator:run). J'ai aussi ajouté un flag handleBsdd aux éco-organismes, et ajouté la possibilité de filtrer la query EcoOrganismes par ces flags, et ajouté ces filtres dans les composant de choix d'éco-organisme en front.J'ai modif à la main les éco-organismes pas à jour mais déjà présents en DB (à faire en sandbox et prod une fois validé en recette)
Points de vigilance pour les intégrateurs
Démo
ecoorganism.filters.mov
Ticket Favro
Revoir la liste des éco-organismes sur les bordereaux (BSDD, BSDA, DASRI et VHU)
Checklist