MelBands algorithm updates #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dbogdanov
commented
Mar 29, 2019
dbogdanov
commented
- Implement correct slaneyMel mel scale conversion formula
- use 'htkMel' scale by default
- Update unit tests, add regression tests
Previously, the 'slaneyMel' scale was introduced in 9dff282, where it was erroneously computed using the HTK Mel scale re-using our previous code for Mel scale computation in MelBands. Use a new correct function from essentiamath.h to compute Mel scale conversion following Slaney's formula. Set htkMel as the default scale to ensure backwards compatibility with all previous versions of the MelBands algorithm.
- Fix failing testWrongInputSize test - Add flat spectrum tests for both htkMel and slaneyMel - Add regression tests for htkMel and slaneyMel
Merge Travis deploy updates for PRs
Add 'unit_tri' triangle area normalizations by the estimated band bandwidth for compatibility with Mel bands implementation in Librosa
These tests ensure compatibility with Librosa
Following the same update in MelBands (112de48).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.