Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Memory error during checksum validation #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

annabeth97c
Copy link

Issue:

This pull request addresses a MemoryError issue encountered when computing the SHA256 checksum for validation of each downloaded tar

Changes:

Modified the compute_sha256 function to read files in chunks rather than loading them entirely into memory.

Verified the fix, the script is able to run without a crash

Included screenshots demonstrating the issue before the fix and the successful execution after the fix.
Added system memory usage information (free -h) to provide context for a system where the issue should be replicable

Screenshots:

Screenshot 1: Error encountered when processing a download
Screenshot 2024-03-23 at 3 25 58 PM

Screenshot 2: Successful execution after implementing chunked reading
Screenshot 2024-03-23 at 3 39 29 PM

System Memory Usage
Screenshot 2024-03-23 at 4 12 17 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant