Reorder the tearDownClass cleanup

Fixes an issue where rmtree tries to access and consequently remove
a temp folder where the server has opened a file already.
This results in error:
"PermissionError: [WinError 32] The process cannot access the file
because it is being used by another process"

For reference read:
theupdateframework#1119

Signed-off-by: Martin Vrachev <mvrachev@vmware.com>

tests/test_arbitrary_package_attack.py

@@ -82,12 +82,13 @@ def setUpClass(cls):
 
   @classmethod
   def tearDownClass(cls):
+    # Kills the server subprocess and closes the temp file used for logging.
+    cls.server_process_handler.clean()
+
     # Remove the temporary repository directory, which should contain all the
     # metadata, targets, and key files generated of all the test cases.
     shutil.rmtree(cls.temporary_directory)
 
-    # Kills the server subprocess and closes the temp file used for logging.
-    cls.server_process_handler.clean()
 
 
 

tests/test_endless_data_attack.py

@@ -84,12 +84,13 @@ def setUpClass(cls):
 
   @classmethod
   def tearDownClass(cls):
+    # Kills the server subprocess and closes the temp file used for logging.
+    cls.server_process_handler.clean()
+
     # Remove the temporary repository directory, which should contain all the
     # metadata, targets, and key files generated of all the test cases.
     shutil.rmtree(cls.temporary_directory)
 
-    # Kills the server subprocess and closes the temp file used for logging.
-    cls.server_process_handler.clean()
 
 
 

tests/test_extraneous_dependencies_attack.py

@@ -88,12 +88,13 @@ def setUpClass(cls):
 
   @classmethod
   def tearDownClass(cls):
+    # Kills the server subprocess and closes the temp file used for logging.
+    cls.server_process_handler.clean()
+
     # Remove the temporary repository directory, which should contain all the
     # metadata, targets, and key files generated of all the test cases.
     shutil.rmtree(cls.temporary_directory)
 
-    # Kills the server subprocess and closes the temp file used for logging.
-    cls.server_process_handler.clean()
 
 
 

tests/test_indefinite_freeze_attack.py

@@ -96,12 +96,13 @@ def setUpClass(cls):
 
   @classmethod
   def tearDownClass(cls):
+    # Kills the server subprocess and closes the temp file used for logging.
+    cls.server_process_handler.clean()
+
     # Remove the temporary repository directory, which should contain all the
     # metadata, targets, and key files generated of all the test cases.
     shutil.rmtree(cls.temporary_directory)
 
-    # Kills the server subprocess and closes the temp file used for logging.
-    cls.server_process_handler.clean()
 
 
 

tests/test_key_revocation_integration.py

@@ -83,12 +83,13 @@ def setUpClass(cls):
 
   @classmethod
   def tearDownClass(cls):
+    # Kills the server subprocess and closes the temp file used for logging.
+    cls.server_process_handler.clean()
+
     # Remove the temporary repository directory, which should contain all the
     # metadata, targets, and key files generated for the test cases.
     shutil.rmtree(cls.temporary_directory)
 
-    # Kills the server subprocess and closes the temp file used for logging.
-    cls.server_process_handler.clean()
 
 
 

tests/test_mix_and_match_attack.py

@@ -87,12 +87,13 @@ def setUpClass(cls):
 
   @classmethod
   def tearDownClass(cls):
+    # Kills the server subprocess and closes the temp file used for logging.
+    cls.server_process_handler.clean()
+
     # Remove the temporary repository directory, which should contain all the
     # metadata, targets, and key files generated of all the test cases.
     shutil.rmtree(cls.temporary_directory)
 
-    # Kills the server subprocess and closes the temp file used for logging.
-    cls.server_process_handler.clean()
 
 
 

tests/test_replay_attack.py

@@ -87,12 +87,13 @@ def setUpClass(cls):
 
   @classmethod
   def tearDownClass(cls):
+    # Kills the server subprocess and closes the temp file used for logging.
+    cls.server_process_handler.clean()
+
     # Remove the temporary repository directory, which should contain all the
     # metadata, targets, and key files generated of all the test cases.
     shutil.rmtree(cls.temporary_directory)
 
-    # Kills the server subprocess and closes the temp file used for logging.
-    cls.server_process_handler.clean()
 
 
 

tests/test_updater.py

@@ -107,12 +107,13 @@ def setUpClass(cls):
 
   @classmethod
   def tearDownClass(cls):
+    # Kills the server subprocess and closes the temp file used for logging.
+    cls.server_process_handler.clean()
+
     # Remove the temporary repository directory, which should contain all the
     # metadata, targets, and key files generated for the test cases
     shutil.rmtree(cls.temporary_directory)
 
-    # Kills the server subprocess and closes the temp file used for logging.
-    cls.server_process_handler.clean()
 
 
   def setUp(self):

tests/test_updater_root_rotation_integration.py

@@ -91,12 +91,13 @@ def setUpClass(cls):
 
   @classmethod
   def tearDownClass(cls):
+    # Kills the server subprocess and closes the temp file used for logging.
+    cls.server_process_handler.clean()
+
     # Remove the temporary repository directory, which should contain all the
     # metadata, targets, and key files generated for the test cases.
     shutil.rmtree(cls.temporary_directory)
 
-    # Kills the server subprocess and closes the temp file used for logging.
-    cls.server_process_handler.clean()