Upgrade Node.js to v20 (LTS) #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see the release schedule here: https://raw.githubusercontent.com/nodejs/Release/main/schedule.svg
Instead of the insecure MD4, we use SHA256. The solution was proposed here: https://stackoverflow.com/a/72219174/
fosterfarrell9
previously approved these changes
Jan 5, 2024
We do this even though we currently don't use this Dockerfile.
|
Oh no, thanks I simply forgot about it 🙈 It's not used right now, that's true. I've still updated it to keep the symmetry. I need another approval then. |
fosterfarrell9
approved these changes
Jan 5, 2024
Splines
added a commit
that referenced
this pull request
Jan 6, 2024
* Upgrade Node.js to v20 (LTS) see the release schedule here: https://raw.githubusercontent.com/nodejs/Release/main/schedule.svg * Use secure hash algorithm for webpack Instead of the insecure MD4, we use SHA256. The solution was proposed here: https://stackoverflow.com/a/72219174/ * Refactor: extract variable * Upgrade node version also for cypress tests We do this even though we currently don't use this Dockerfile.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade Node.js to v20.10.0 (LTS until April 2026).
I tested this on theNope, that's what I hoped, but of course the old error keeps hunting us.experimentalbranch and the run was successful (see Dozzle). Also check out mampf-experimental.And we are not alone, the question for this error was viewed 2.5million times on Stack overflow here! I will fix this! maybe useful
Finally fixed
In 8f67ce9, I finally fixed this issue after several failed attempts. See the comment in the code for further details. The
experimentalbranch currently also points to this commit and you can see in the logs that it's working. mampf-experimental also shows the monotiles on the landing page.