Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The No Content option of Search is not correctly handled #9

Closed
MacFJA opened this issue Jul 23, 2021 · 0 comments · Fixed by #13
Closed

The No Content option of Search is not correctly handled #9

MacFJA opened this issue Jul 23, 2021 · 0 comments · Fixed by #13
Labels
bug Something isn't working

Comments

@MacFJA
Copy link
Owner

MacFJA commented Jul 23, 2021

If the option NoContent of the search is specified, the command always fail because of the test here:

php-redisearch/src/Search.php

Line 460 in d417e7d

if (!(1 === count($document))) {

(If NoContent is enabled, at this point, $document is empty)
@MacFJA MacFJA added the bug Something isn't working label Jul 23, 2021
@MacFJA MacFJA mentioned this issue Jul 28, 2021
Closed
MacFJA added a commit that referenced this issue Aug 6, 2021
@MacFJA
Handle search result with NoContent flag.
7351a04 
Fix #9 and #10
@MacFJA MacFJA mentioned this issue Aug 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle search result with NoContent flag. MacFJA/php-redisearch
1 participant
@MacFJA