Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the m4a content type sent as mp4 instead #197

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

Demircivi
Copy link
Contributor

@Demircivi Demircivi commented Apr 10, 2024

What

It fixes the trouble caused by sending the content type for m4a as mp4.
Fixes #194 and #195.

Why

Out of nothing, I started to get message : "Invalid file format. Supported formats: [\'flac\', \'m4a\', \'mp3\', \'mp4\', \'mpeg\', \'mpga\', \'oga\', \'ogg\', \'wav\', \'webm\']" error when I try to transcribe my voice records. The weird part was that the file type was m4a and was in the supported formats list.

The code was as follows:

client.audioTranscriptions(query: .init(file: data, fileType: .m4a, model: .whisper_1)) { /* ... */ }

Affected Areas

AudioTranscriptionQuery.swift

Copy link

sonarcloud bot commented Apr 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

This was referenced Apr 10, 2024
Copy link

@pradeepb28 pradeepb28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pradeepb28
Copy link

someone from MacPaw team please review and approve the PR, it affected all the existing apps that uses .m4a files

@pradeepb28
Copy link

It is disappointing that the PR has not been merged even after two weeks. This bug-fix PR is crucial for fixing all production apps that rely on voice input.

@Krivoblotsky Krivoblotsky self-requested a review April 21, 2024 07:34
@Krivoblotsky Krivoblotsky merged commit 51726a6 into MacPaw:main Apr 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AudioTranscription Fails
3 participants