-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(basePath): enable base path for configuration #69
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's improve paths logic 🙏
Done refactoring and unit tests added. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
The functionality of this PR is needed, but it seems like Merge is stuck @metrue @Krivoblotsky |
Hey, everyone! |
Also, I need to check why the build is failing |
Cool, thanks so much 🙏 |
hey @Krivoblotsky I checked the CI log, it does tell why it failed,
And I run
|
@metrue, thanks! |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Hi, how is this PR coming along? Customizing the endpoints is necessary and I'm looking forward to this feature. |
Going a step further, we can customize the entire endpoint, not just the base path, because sometimes we build the OpenAI service locally, when it's an Therefore, I hope to provide an |
I need this |
Hi, how's this going? |
还没搞定吗? |
Quality Gate passedIssues Measures |
Due to the lack of developers handling this issue, I added a new public API myself to make it easier to support user-defined request URLs, just for my own convenience, and also submitted a PR #204 . Can be used simply as follows: openAI.chatsStream(query: query, url:"http://localhost:11434/v1/chat/completions") |
What
This MR is to resolve the issue #68 (comment)
Why
When we set up a proxy for OpenAI API, sometimes we enable a custom endpoint for it, so enabling a base path for the configuration would be helpful when we have something like 'my.host.com/openai/api' proxying OpenAI API.
Affected Areas
Configuration to initialize the OpenAI API instance but it's backward compatible.