Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue where chatsStream() throws incorrect error #87

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Fix issue where chatsStream() throws incorrect error #87

merged 1 commit into from
Jul 10, 2023

Conversation

longseespace
Copy link
Contributor

What

This PR fixes the regression bug where it throws incorrect error when streaming

Reference: #23

Affected Areas

OpenAI.chatsStream(), StreamingSession

@longseespace longseespace mentioned this pull request Jul 6, 2023
Closed
PallavAg
PallavAg approved these changes Jul 8, 2023
View reviewed changes
Copy link
Contributor

@PallavAg PallavAg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faced the same issue - was getting a The data couldn’t be read because it is missing. for all errors.

Was able to use this fix and it works great.

Krivoblotsky
Krivoblotsky reviewed Jul 8, 2023
View reviewed changes
Copy link
Collaborator

@Krivoblotsky Krivoblotsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move port and scheme into separate PR, and we'll merge it.
Thanks!

Sources/OpenAI/OpenAI.swift Outdated Show resolved Hide resolved
@longseespace
Copy link
Contributor Author

Oh wow. I totally forgot about this PR. Sorry 😅

Will do soon!

Krivoblotsky
Krivoblotsky approved these changes Jul 8, 2023
View reviewed changes
Copy link
Collaborator

@Krivoblotsky Krivoblotsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks 👍

@Krivoblotsky Krivoblotsky merged commit a51a7fd into MacPaw:main Jul 10, 2023
@longseespace longseespace mentioned this pull request Jul 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PallavAg PallavAg PallavAg approved these changes

@Krivoblotsky Krivoblotsky Krivoblotsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@longseespace @Krivoblotsky @PallavAg