-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding the new package ResolutionsOfStanleyReisnerRings #1511
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution.
… function, removing named outputs in documentation, and adding pacakge name to distributed packages file
Let me know when you consider your changes complete. |
m := max(ColorsNotAllowed) + 1; | ||
Colors#m = append(Colors#m,R_c); | ||
AlreadyColored = append(AlreadyColored,c); | ||
NotColored = delete(c,NotColored); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Faster than appending to a list and checking for membership later would be use a mutable hash table here.
Also, creating a list by appending one element at a time can be very slow for long lists, as the list has to get copied each time. Can you do it a different way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the structure of the algorithm, only one element (an integer) needs to be added to the list. With my understanding of m2, append is still the most efficient way to add one element onto both mutable and immutable lists, which is why these two lines of code remain unchanged.
Can you get these changes made during the next week so this new package can be include in version 1.17? |
ResolutionsOfStanleyReisnerRings was mentioned twice
... for packages mentioned twice in the list of packages.
@DanGrayson did you mean to add these commits to this branch? |
Yes. They'll get merged in eventually. |
Let me know when this is ready to be reconsidered. |
I'm so sorry. I didn't realize my github account was set to send all notifications of activity to an email address I don't use often. I'm working on getting these edits finished asap. |
No problem, I'll be patient. I have lots of email addresses, but I've set them all to forward all the email to my gmail address. That way I only have to read email from one location. |
Pending your responses to the two remaining issues, I believe the code is ready to be considered again. Once again, I'm sorry for the email issue. It's been resolved for any future notifications. |
I'll add a keyword to your package. Which one would you like? Here are the ones already in use, in case one of them appeals to you: o12 = Algebraic Geometry
Algebraic Number Theory
Algebraic Statistics
Applied Algebraic Geometry
Combinatorial Commutative Algebra
Combinatorics
Commutative Algebra
Convex Geometry
D-modules
Deformation Theory
Edge Ideals
Equivariant Cohomology
Examples and Random Objects
Flag Varieties
Graph Theory
Groebner Basis Algorithms
Group Theory
Homological Algebra
Interfaces
Intersection Theory
Lie Groups and Lie Algebras
Linear Algebra
Matroids
Miscellaneous
Noncommutative Algebra
Numerical Algebraic Geometry
Numerical Linear Algebra
Real Algebraic Geometry
Representation Theory
Statistics
Toric Geometry
Tropical Geometry |
I think "Combinatorial Commutative Algebra" is the closest match. |
Okay, I've added it. |
Routines for comparing resolutions of Stanley-Reisner rings and computing various systems of parameters.