-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AbstractSimplicialComplexes.m2 and SpectralSequences.m2 #3548
Conversation
This package gives a way to work with simplicial complexes implemented as graded lists. It complements the existing M2 package SimplicialComplexes.m2.
fixed Lint / codespell errors.
This PR is using the same branch as #3547 -- closing |
"Identifying anti-podal points of the two sphere" | ||
"Spectral sequences and non-Koszul syzygies" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there just some reordering of the documentation nodes happening here? The differences looks very large so it's hard to tell.
No, this is a larger update making the package forward compatible with the Complexes update. So many parts of the code have changed and become reordered in various parts.
Best,
Nathan
… On Oct 27, 2024, at 10:10 PM, Mahrud Sayrafi ***@***.***> wrote:
@mahrud commented on this pull request.
In M2/Macaulay2/packages/SpectralSequences.m2 <#3548 (comment)>:
> - "Identifying anti-podal points of the two sphere"
+ "Spectral sequences and non-Koszul syzygies"
Is there just some reordering of the documentation nodes happening here? The differences looks very large so it's hard to tell.
—
Reply to this email directly, view it on GitHub <#3548 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABC62JCSM7NKQBYYNIXG7K3Z5V6HZAVCNFSM6AAAAABQWKJDVOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGOJXG4YTKOBZGY>.
You are receiving this because you authored the thread.
|
I see. I would suggest splitting the package into several smaller files, similar to
|
Many thanks for these suggestions. Eventually, we may try to do that with future updates.
Best,
Nathan
… On Oct 27, 2024, at 10:55 PM, Mahrud Sayrafi ***@***.***> wrote:
I see. I would suggest splitting the package into several smaller files, similar to NormalToricVarieties or Complexes or Varieties, or even much simpler:
SpectralSequences.m2
SpectralSequences/docs.m2
SpectralSequences/tests.m2
—
Reply to this email directly, view it on GitHub <#3548 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABC62JFROBOERTR2RGAZEXDZ5WDO7AVCNFSM6AAAAABQWKJDVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBQGM2DGMBUGI>.
You are receiving this because you authored the thread.
|
No description provided.