Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed code for eagonNorthcott complex #802

Merged
merged 3 commits into from
Jun 9, 2018

Conversation

emduart2
Copy link
Contributor

@emduart2 emduart2 commented Jun 7, 2018

Updated the code of the eagonNorthcott complex. tIt now displays the correct degrees of the matrices in the case that the input matrix is homogeneous but whose entries are not necessarily linear forms.

@DanGrayson DanGrayson added this to the version 1.11.1 milestone Jun 7, 2018
@DanGrayson DanGrayson self-assigned this Jun 7, 2018
@DanGrayson
Copy link
Member

Thank you, Eliana!

But, how about installing some tests, so it is ensured to continue to work?

@DanGrayson
Copy link
Member

If there is a suitable test, you could remove this assertion and save time:

assert isHomogeneous(chainComplex d);

@DanGrayson DanGrayson merged commit 9d94b33 into Macaulay2:master Jun 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants