Fix bug in handling zeros

Macaulay2 · Dec 7, 2023 · 536af0a · 536af0a
1 parent 91ae830
commit 536af0a
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/Valuations/Valuations.m2 b/Valuations/Valuations.m2
@@ -77,11 +77,12 @@ internalValuation (Function, Thing, Thing) := (v, S, T) -> (
         }
     )
 
+-- Concerns with subrings and local rings, will need testing.
 Valuation Thing := (v,t) -> (
     if (v#"domain" === null) or (ring t) === v#"domain" then
-    -- Concerns with comparing things like ZZ and QQ
-    -- Concerns with subrings and local rings, will need testing.
-    v#"function" t
+        v#"function" t
+    else if (isMember(ring t, v#"domain".baseRings)) then
+        v#"function" promote(t, v#"domain")
     )
 
 --------------------------------------------------------------------------------