Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

factory: revision bump #218

Closed
wants to merge 1 commit into from
Closed

Conversation

d-torrance
Copy link
Member

Build against FLINT 3.1.0 (I think this is why the autotools-macos builds are failing in the main M2 repository...)

Build against FLINT 3.1.0
@d-torrance
Copy link
Member Author

d-torrance commented Mar 9, 2024

@mahrud - Am I correct that you would need to add the pr-pull label to this to publish the bottles that were built? (Assuming this whole idea was even correct -- I'm not really sure!)

@mahrud
Copy link
Member

mahrud commented Mar 9, 2024

Yes, but this factory is already against the latest flint, so there is no need.

@d-torrance
Copy link
Member Author

Ah, ok! Something's weird with the current bottle, which is causing the autotools-macos builds to fail. We're getting this during the "Install requirements for macOS" step:

==> Reinstalling 2 dependents with broken linkage from source:
macaulay2/tap/factory, macaulay2/tap/normaliz

Which means that pkg-config doesn't find factory, so autotools builds it from some old tarball that doesn't have the new FLINT 3.1.0 patches.

It appears that running brew link factory fixes things, based on this GitHub action I put together. But is that something we would need to add to the M2 action, or is there a better fix?

@mahrud
Copy link
Member

mahrud commented Mar 9, 2024

I think the problem is that, for whatever reason, an older version of flint is being downloaded:

==> Downloading https://ghcr.io/v2/homebrew/core/flint/manifests/3.0.1

I can't tell why ...

@d-torrance d-torrance closed this Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants