-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2 (very) minor fixes to the theming documentation #274
2 (very) minor fixes to the theming documentation #274
Conversation
Hi, thanks for fixing those :) Perhaps you're using an older version of |
I just installed the version from the arch repos, and it didn't seem to change the line first line listing the version so I'm not sure. Ironically, this tool has a very short and unhelpful (imo) man page |
As a side note, I was wondering, would it be possible to add functionality to choose what order the items are displayed in? There's other changes I'd like to make too since I'm trying to replace my very customised neofetch with this tool as it is unbelievably faster. I am however not super experienced with rust and cli tools but the code seems easy enough to understand. |
I would say the man page is a lot less "wordy" than usual and good enough to get AsciiDoc refugees started and on their way. At any rate, I don't think the large diff is an issue. |
This suggestion should probably be in a separate issue. I've always had a bad taste working with file formats, it's something I'm working on, though. Anyways, I never really bothered to implement the feature, probably because I don't mind the current order. However, I'd like to see it added some day. |
Sorry in case there was a misunderstanding, your man page is great, I was talking about the |
Yeah, I was referring to the |
Haha my bad then. Brand new to me but I guess it was enough for this AsciiDoc refugee.
I can make an issue if you would like. I was more asking if it is possible without major breaking changes so I could try work on it since as you it says on the README you guys are busy with other projects right? |
I don't think there'd be any breaking changes or major codebase restructures. I assume we'd have to modify the TOML parser a bit to take the order in which things appear into account.
Yeah, I've been a bit busy with academia and other interests (Emacs, primarily). I am however always on the lookout and don't mind doing an in depth review or guiding contributors along as they implement the features they'd like to add. |
Well I'll start looking into making a pr for that then, and open an issue for it if I need some guidance, thanks. |
Awesome, thanks again! |
I only made 2 very small changes to the documentation file but running
scdoc < macchina.7.scd > macchina.7
seems to have made a lot of changes. I've never really used thescdoc
tool but please let me know if this is an issue and how I can fix it.