Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 (very) minor fixes to the theming documentation #274

Merged
merged 1 commit into from
Feb 26, 2023

Conversation

Rolv-Apneseth
Copy link
Contributor

I only made 2 very small changes to the documentation file but running scdoc < macchina.7.scd > macchina.7 seems to have made a lot of changes. I've never really used the scdoc tool but please let me know if this is an issue and how I can fix it.

@grtcdr
Copy link
Member

grtcdr commented Feb 26, 2023

Hi, thanks for fixing those :)

Perhaps you're using an older version of scdoc, though it could very well be the document that's in dire need of a recompile.

@Rolv-Apneseth
Copy link
Contributor Author

I just installed the version from the arch repos, and it didn't seem to change the line first line listing the version so I'm not sure. Ironically, this tool has a very short and unhelpful (imo) man page

@Rolv-Apneseth
Copy link
Contributor Author

As a side note, I was wondering, would it be possible to add functionality to choose what order the items are displayed in? There's other changes I'd like to make too since I'm trying to replace my very customised neofetch with this tool as it is unbelievably faster. I am however not super experienced with rust and cli tools but the code seems easy enough to understand.

@grtcdr
Copy link
Member

grtcdr commented Feb 26, 2023

I just installed the version from the arch repos, and it didn't seem to change the line first line listing the version so I'm not sure. Ironically, this tool has a very short and unhelpful (imo) man page

I would say the man page is a lot less "wordy" than usual and good enough to get AsciiDoc refugees started and on their way. At any rate, I don't think the large diff is an issue.

@grtcdr
Copy link
Member

grtcdr commented Feb 26, 2023

As a side note, I was wondering, would it be possible to add functionality to choose what order the items are displayed in? There's other changes I'd like to make too since I'm trying to replace my very customised neofetch with this tool as it is unbelievably faster. I am however not super experienced with rust and cli tools but the code seems easy enough to understand.

This suggestion should probably be in a separate issue. I've always had a bad taste working with file formats, it's something I'm working on, though. Anyways, I never really bothered to implement the feature, probably because I don't mind the current order. However, I'd like to see it added some day.

@Rolv-Apneseth
Copy link
Contributor Author

Sorry in case there was a misunderstanding, your man page is great, I was talking about the scdoc man page

@grtcdr
Copy link
Member

grtcdr commented Feb 26, 2023

Sorry in case there was a misunderstanding, your man page is great, I was talking about the scdoc man page

Yeah, I was referring to the scdoc man pages too.

@Rolv-Apneseth
Copy link
Contributor Author

Yeah, I was referring to the scdoc man pages too.

Haha my bad then. Brand new to me but I guess it was enough for this AsciiDoc refugee.

This suggestion should probably be in a separate issue.

I can make an issue if you would like. I was more asking if it is possible without major breaking changes so I could try work on it since as you it says on the README you guys are busy with other projects right?

@grtcdr
Copy link
Member

grtcdr commented Feb 26, 2023

I can make an issue if you would like. I was more asking if it is possible without major breaking changes so I could try work on it since as you it says on the README you guys are busy with other projects right?

I don't think there'd be any breaking changes or major codebase restructures. I assume we'd have to modify the TOML parser a bit to take the order in which things appear into account.

since as you it says on the README you guys are busy with other projects right?

Yeah, I've been a bit busy with academia and other interests (Emacs, primarily). I am however always on the lookout and don't mind doing an in depth review or guiding contributors along as they implement the features they'd like to add.

@Rolv-Apneseth
Copy link
Contributor Author

Well I'll start looking into making a pr for that then, and open an issue for it if I need some guidance, thanks.

@grtcdr
Copy link
Member

grtcdr commented Feb 26, 2023

Awesome, thanks again!

@grtcdr grtcdr merged commit 0de459f into Macchina-CLI:main Feb 26, 2023
@Rolv-Apneseth Rolv-Apneseth deleted the minor-fix-documentation branch September 29, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants