Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning messages #51

Merged
merged 8 commits into from
Apr 5, 2022
Merged

Warning messages #51

merged 8 commits into from
Apr 5, 2022

Conversation

jackaraz
Copy link
Member

@jackaraz jackaraz commented Mar 17, 2022

Warning messages are limited to be shown once. All of the warning messages can be seen in summary. See issue #50

Modifications in the code:

  • Track formation request for particle ID is silinced if shower evolution generated an unknown particle.
  • Delphes genparticle finder warning message is wrapped with proper error handler to limit with verbosity counter.

@jackaraz jackaraz requested a review from BFuks March 17, 2022 15:37
@jackaraz jackaraz linked an issue Mar 17, 2022 that may be closed by this pull request
@jackaraz
Copy link
Member Author

Unconstrained warning message in the program flow:

MAuint32 nconstituents = static_cast<MAuint32>(ref->Constituents.GetEntries());
for (MAuint32 j=0;j<nconstituents;j++)
{
const GenParticle* mc = dynamic_cast<const GenParticle*>(ref->Constituents.At(j));
if (mc!=0)
{
genit = gentable.find(mc);
if (genit!=gentable.end()) vertex->constituents_.push_back(&(myEvent.mc()->particles()[genit->second]));
else WARNING << "GenParticle corresponding to a vertex is not found in the gen table" << endmsg;
}
// vertex->delphesTags_.push_back(reinterpret_cast<MAuint64>(mc));

This error needs to be caught by the program.

@jackaraz jackaraz marked this pull request as draft March 18, 2022 13:53
@jackaraz jackaraz linked an issue Mar 18, 2022 that may be closed by this pull request
Copy link
Member Author

@jackaraz jackaraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible drawbacks.

tools/SampleAnalyzer/Commons/Service/LogReport.h Outdated Show resolved Hide resolved
@jackaraz jackaraz marked this pull request as ready for review March 22, 2022 17:45
@jackaraz jackaraz removed a link to an issue Mar 22, 2022
@MadAnalysis MadAnalysis deleted a comment from Bearpepe Mar 23, 2022
@BFuks BFuks merged commit 43a1f3b into main Apr 5, 2022
@BFuks BFuks deleted the warnings branch April 5, 2022 19:06
@Bearpepe
Copy link

Bearpepe commented Apr 7, 2022

Thanks for looking out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warnings during the analysis execution
3 participants