This repository has been archived by the owner on Mar 7, 2023. It is now read-only.
Use native Promises #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@timfish Seems fine. We should update the |
|
Updated engines to >=4 |
|
Thanks @timfish ❤️ I looked through the code to make sure we weren't using any specific bluebird methods and ran the test suite ✔️ |
|
This is now part of v4.0.0 🚀 , https://github.com/MadLittleMods/node-usb-detection/blob/master/CHANGELOG.md#v400---2018-9-27 Waiting on the Update: v4.0.0 published to npm, https://www.npmjs.com/package/usb-detection |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node has had native promises since v4 so I don't think bluebird is required.