Skip to content
This repository has been archived by the owner on Mar 7, 2023. It is now read-only.

Updated type definitions for 4.5.0 #90

Merged
merged 1 commit into from
Nov 25, 2019
Merged

Updated type definitions for 4.5.0 #90

merged 1 commit into from
Nov 25, 2019

Conversation

RicoBrase
Copy link
Contributor

Updated type definitions to node-usb-detection 4.5.0

Old type definitions only allowed find() function to return a Promise object, if the function was called without parameters.

The updated type definitions now accept find(vid) and find(vid, pid) as Promise-based functions as well - just as stated in the ReadMe:

Note: All find calls return a promise even with the node-style callback flavors

Technically, the type definitons currently wont allow find() to be called with callback function parameter AND returning a Promise either - I could add that too, if desired.

Updated type definitions to node-usb-detection 4.5.0
@MadLittleMods MadLittleMods merged commit ddcfc29 into MadLittleMods:master Nov 25, 2019
MadLittleMods added a commit that referenced this pull request Nov 25, 2019
@MadLittleMods
Copy link
Owner

Thanks for the update @RicoBrase! Nice incremental improvement 👍

@RicoBrase
Copy link
Contributor Author

You're welcome. Feel free to contact me, if the type definitions need an update.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants