Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for workflow summary #89

Merged
merged 5 commits into from
Sep 18, 2024
Merged

Support for workflow summary #89

merged 5 commits into from
Sep 18, 2024

Conversation

yijhenlin
Copy link
Contributor

Add an option for workflow summary.
Fix #88

@thsaravana
Copy link
Member

thsaravana commented Sep 18, 2024 •
edited
Loading

Sorry about the late reply. We just picking this for milestone v1.7.2. The dist is auto-generated files. Could you make the changes to the .ts files with this change?

@thsaravana thsaravana changed the base branch from main to workflow_summary September 18, 2024 17:22
@thsaravana
Copy link
Member

We are taking a different approach to this:

  1. We will have an option to either do a PR Comment or Workflow Summary, as well as "both" at the same time. We will develop this further on adding more detailed report in the workflow summary later.
  2. The token can't be optional, since we are using this to calculate the "changed files". So we are going to keep it required

We would still like to give you credit for raising the issue and raising the initial PR. Thanks!

@thsaravana thsaravana merged commit 4943c7b into Madrapps:workflow_summary Sep 18, 2024
1 check passed
thsaravana added a commit that referenced this pull request Sep 18, 2024
@thsaravana @yijhenlin
Support for Workflow Summary (#143)
ad47d82 
* Write to workflow summary

* Write to workflow summary - only body

* Add choice type

* Print comment-type

* Run build

* Adding commentType validation

* Code cleanup

* Adapt tests

* Adding more tests

* Adding tests for validation

* Support for workflow summary (#89)

* Add summary_mode

* Token is not necessary for workflow summary

* Add summary_mode in action.ts

* Update description for comment-type field

---------

Co-authored-by: thsaravana <th.saravana@gmail.com>

---------

Co-authored-by: YiJhen Lin <44198696+yijhenlin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thsaravana thsaravana thsaravana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for workflow summary
2 participants
@yijhenlin @thsaravana