Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nickname must be a property because it's immutable #88

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

Deewarz
Copy link
Contributor

@Deewarz Deewarz commented Jan 21, 2024

Followed by: MafiaHub/MafiaMP#60

Also, maybe it shouldn't be on all entities but only on the player (via an interface?) but that's another story.

@Deewarz Deewarz self-assigned this Jan 21, 2024
@Deewarz Deewarz marked this pull request as ready for review January 21, 2024 16:38
@Deewarz Deewarz requested a review from zpl-zak January 21, 2024 16:38
@Deewarz Deewarz changed the title Nickname should be a property since is immutable Nickname must be a property because it's immutable Jan 21, 2024
@Deewarz Deewarz merged commit f619ffd into develop Jan 21, 2024
3 of 5 checks passed
@Deewarz Deewarz deleted the entity-nickname-property branch January 21, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants