Add PHP7, phpspec 3 and Behat 3 support #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The EAV attributes are now used to validate the inbound data supplied to create a fixture.
@svalaskevicius Not sure why this was in place but it breaks validation of attributes and functionality seems the same after removal.
feature/licensing
ClassGuesser provides ability to use predefined steps withtout the need to create FeatureContext. There's not enough predefined magento steps to do that just yet and also provided guesser is wrong.
We decided that cache is part of application and implementation layer, not the business logic, so it doesn't make sense to clear this automatically. There is still a step for that task though.
…o use BehatMage as intented by its developers
…o use BehatMage as intented by its developers
…o use BehatMage as intented by its developers
…o use BehatMage as intented by its developers
…o use BehatMage as intented by its developers
Documentation improvement
how to contribute back to the project
ask for guidance when needed
Each cache type can consist of one or more cache tags. This patch uses the cache tags that have been configured in magento for each cache segment instead of using a single hardcoded 'config' tag. This touches on issue #19, but doesn't resolve it completely yet.
behat3 removing fixtures
Extend RawMinkContext rather than MinkContext
Support all Behat 3 minor releases
This was referenced Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on the original work performed by a group of very talented engineers.
I've only added the following on top:
5.6and7.0+ (older versions of PHP are not supported by Travis any longer)