Skip to content

Commit

Permalink
ignore strange errors from systeminformation under aarch64 (#3349)
Browse files Browse the repository at this point in the history
by excluding them from global error handling, see discussions in
#3337
  • Loading branch information
khassel authored Jan 14, 2024
1 parent dadc7ba commit f890f14
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ _This release is scheduled to be released on 2024-04-01._

### Added

- Output of system information to the console for troubleshooting (#3328 and #3337)
- Output of system information to the console for troubleshooting (#3328 and #3337), ignore errors under aarch64

### Updated

Expand Down
11 changes: 7 additions & 4 deletions js/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,13 @@ if (process.env.MM_PORT) {
// The next part is here to prevent a major exception when there
// is no internet connection. This could probable be solved better.
process.on("uncaughtException", function (err) {
Log.error("Whoops! There was an uncaught exception...");
Log.error(err);
Log.error("MagicMirror² will not quit, but it might be a good idea to check why this happened. Maybe no internet connection?");
Log.error("If you think this really is an issue, please open an issue on GitHub: https://github.com/MagicMirrorOrg/MagicMirror/issues");
// ignore strange exceptions under aarch64 coming from systeminformation:
if (!err.stack.includes("node_modules/systeminformation")) {
Log.error("Whoops! There was an uncaught exception...");
Log.error(err);
Log.error("MagicMirror² will not quit, but it might be a good idea to check why this happened. Maybe no internet connection?");
Log.error("If you think this really is an issue, please open an issue on GitHub: https://github.com/MagicMirrorOrg/MagicMirror/issues");
}
});

/**
Expand Down

0 comments on commit f890f14

Please sign in to comment.