-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeshift calendar issue / Recurring Google Calendar events for times when UTC date differ from local date appear at wrong time in MM #1798
Comments
same problem here |
same here in PST |
same here edit the quick fix #1568 wont resolve the problem |
Same issue observed here as well. The issue presents itself on some third party calendar modules I tested as well. Issue is occurring on two separate mirrors. |
Same here. Shift from summer time to winter time results in recurring events show up one hour too early. |
Can this be related to #1803 ? |
It seems that everyone is referencing other post and it has become a circular post. #37 Is there a fix for this yer? |
It is also present when a repeating event crosses time change date (for example change from standard time to daylight savings time) |
Same problem here. |
Do you mean the source files or the files that the module downloads from the calendar app (e.g. Google Calendar)? |
PR #1884 submitted for a possible fix to this. My wife and I were having this same issue on our calendar and were able to fix ours with this workaround. Would welcome any comments / further testing on it to see if it fixes yours as well. |
fix: Issue #1798 - fixing recurrent calendar events crosstime DST
Merged your commit (ignore the accidental revert notification). Hope this solves the issue. |
I still encounter problems with the latest version. rolling back the calendar module to the one from 2.7.1 fixes this problem for me |
@Kugelfang666 is it the same issue listed above or a different one? There was a comment on my PR that I missed "month +1" so I am putting that fix up now so it may just be that we are off by a month. can you share an example of what you are seeing right now (snap shot / test ics that I can use to verify against, or the following details:
Thanks for any help you can provide to further troubleshoot |
@kblankenship1989 i was refearing to t he issue where full day events are shown one day late. If I'm not mistaken this was related to the original -1h bug that causes full day events to be moved |
Reopened |
Hi, |
Same here - here a example ical from Google calender. The calandar - wich is a series entry - is showed on the magicmirror at 09:45 not at the correct time at 11:45
|
Are you willing to help this NOOB do the same? Can you provide a step by
step?
Thank you and have a wonderful day,
*Ryan Jones*
443-801-1974
…On Wed, Sep 9, 2020 at 3:56 AM rbouhet ***@***.***> wrote:
Hi,
Just my 2 cents in case it might help.
I was having the same issue: all days recurring event were displaying one
day early (Sept 12th instead of Sept 13th). I switched to develop branch
(to fix something unrelated, ie Forecast only displaying 2 days) and the
issue is gone.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1798 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQZO3NQUT3XZTHHC6LCFZXLSE4YKBANCNFSM4JG7OOEA>
.
|
Simply go to your MagicMirror folder in command line and checkout develop branch (the git pull might be unnecessary): |
I don't know if it's the same issue or not: I work in an international company, I'm based in CET Time Zone and some people I work with are based in PST Time Zone.
PST:
I would expect the PST meeting to display "2020-09-15 17:30" but it shows up as "2020-09-15 08:30". |
@rbouhet have u tried the develop branch yet, there are fixes for the calendar problem |
@sdetweil yes, I'm on develop branch, The issue I just mentionned probably has a different root since it applies to both recurring and non recurring events. |
I had submitted a fix related to the TZID parsing issue a while ago, but it hasn't been approved: #2086 |
@rbouhet there was a fix for this included when I fixed the recurring not showing today problem (2121). when did u switch to develop? try a git pull to update there IS a problem still with ics rrule parsing in general, and why I had this issue reopened. if u have a little ics file with header and the one event, I can add it to the ics problem |
@sdetweil git pull says I'm already up to date. The ics file is my profesional calendar so I don't feel like sharing it completely is a good idea, but I can give you snippets if you want.
Not these:
When I mean "not correctly", I mean I would expect them to be converted to local time. Here it just seems that TZID is just ignored.
|
@rbouhet could u share the calendar header? u can change the text, just not the time and timezone info. that way I can debug it see the calendar def here #1798 (comment) |
Here is the header (looking at it looks pretty messy? Thanks Office I guess....) |
@rbouhet did u switch to the develop branch? i have tested and don't see anything wrong.. 08:45(ish) US CDT https://www.dropbox.com/s/wmynah0n7lfwaxl/Screenshot_2020-09-10_08-52-04.png?dl=0 |
@sdetweil I switched yesterday (am I suppsoed to npm install again after switching though ?) Here is the time displayed on my side and in red the actual time of the meeting. The CET ones are displayed correctly, but I would expect the PST ones to be converted to CET since that's my time zone. |
no need to npm install, you did that already. ok, still fighting the ics parser library ( not our code) which is returning the event date as local time, using the existing numbers. (it's supposed to return utc time) |
Work life finally got out of my way and I could return to my MagicMirror Project. I can now confirm the fix of Recurring Events time errors and a single day weather forecast is successful. I used an used the installation script (to install MM2). Here is the fix code. Url provided below. cd ~/Magicmirror Thank you for your help and guidance. |
@rbouhet I want to make sure that I am testing correctly.. the tz listed is "W. European Standard Time", NOT CET I added a lookup to the standard ical libs, which will translate from the MS TZ names to the IANA TZ names used everywhere else and by the javascript libs. there may be multiple locations which map to the same MS TZ name.. , for example
to simplify the mapping I take the 1st entry in the list as the IANA tz to use, which makes the adjustment to my current timezone 7 hours, is that correct? |
@rbouhet I have a test fix... I submitted support to the ical.js and node-ical projects but u can test like this
then run MM like normal |
I see that Peter (ical) author states that his module is intended for in browser, and as such has no fs access. I think we need to move to node-ical, which doesn't have this limitation. (stated in it readme) |
Hi @sdetweil , |
@rbouhet great! thanks for the feedback. which module did u test, ical.js or node-ical? |
@rbouhet thanks. that's the ical.js module, altho u said node-ical.. just making sure we are in synch.. thanks again |
this issue can be closed |
Thank you so much @sdetweil for fixing this! I recently added the family calendar on our mirror and these recurring events have not worked properly before now (the timezone issue). After updating to latest it's working perfectly! |
Please only submit reproducible issues.
If you're not sure if it's a real bug or if it's just you, please open a topic on the forum: https://forum.magicmirror.builders/category/15/bug-hunt
Problems installing or configuring your MagicMirror? Check out: https://forum.magicmirror.builders/category/10/troubleshooting
When submitting a new issue, please supply the following information:
Platform: RP3B+
Node Version: 10.17.0
MagicMirror Version: v2.9
Description: Since the time shift in Germany last sunday reocurring events are in the "old time zone (-1h) in Google Calendar they are displayed correctly but on the mirror itself they are displayed wrong.
Steps to Reproduce: make new calendar with reocurring event (not whole day event) and try to display it
Expected Results: the right time
Actual Results: the time -1h
Configuration: -
Do you have any idea how to fix this? The timezones on the raspberry itself is correct
The text was updated successfully, but these errors were encountered: