Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capitalize "y/n" for clearer intent #1224

Merged

Conversation

bacongobbler
Copy link
Contributor

First off, thank you for maintaining and making this project publicly available for others! Fist bump 🤜

During the install script process, if you press enter, choice becomes an empty string and will default to "no". The convention in this case is to capitalize the default answer so users know what happens when they auto-accept prompts.

I figured this is such an insignificant change that it doesn't need a note in the CHANGELOG, but please let me know if you'd prefer I add this in.

Thanks! :)

If you press enter, `choice` is an empty string and will default to "no". The convention is to capitalize the default answer so users know what happens when they auto-accept prompts.
@MagicMirrorBot
Copy link

Warnings
⚠️

Please include an updated CHANGELOG.md file.
This way we can keep track of all the contributions.

Generated by 🚫 dangerJS

@MichMich MichMich merged commit f89bc84 into MagicMirrorOrg:develop Mar 25, 2018
@bacongobbler bacongobbler deleted the clearer-install-question branch June 12, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants