Fix CI #1849

roramirez · 2019-12-31T19:51:01Z

Revert commit introduced in #1827. The change introduce a failure for all e2e tests.

This change revert the commit 2fbedca

--
Happy new year ("20".repeat(2))

This reverts commit 2fbedca.

sdetweil · 2019-12-31T20:58:04Z

NO.. we need the helper fix.. need to fix CI some other way..
the package-lock.json was not updated for this fix...

so maybe travis doesn't have the module loaded...

sdetweil · 2019-12-31T21:02:05Z

the vendor tests still fail.

MichMich · 2020-01-01T12:11:47Z

@sdetweil I Will test this PR tonight. If this fixes the issue I’ll merge it since we need Travis to complete successfully in order to release 2.10 today (according to release schedule).

sdetweil · 2020-01-01T14:54:38Z

How do we fix the testing cache to have the helper in the main node_modules instead the modules/node_modules?

MichMich · 2020-01-01T15:26:42Z

Will try tonight. Don’t want to have the helper in an external repo anyway. Might need to push that change onto the next release.

sdetweil · 2020-01-01T15:43:26Z

I think the helper being erased is a big problem. I think it is a security fix that is erasing. If modules not listed but installed, they are removed

MichMich · 2020-01-01T16:02:16Z

Will look into it. Hope I can fix it before release. Vriendelijke groeten, Michael Teeuw

…

--- Sent from my iPhone. Michael Teeuw Xonay Media www.xonaymedia.nl 06 51 71 36 15

Op 1 jan. 2020 om 16:43 heeft sam detweiler ***@***.***> het volgende geschreven: I think the helper being erased is a big problem. I think it is a security fix that is erasing. If modules not listed but installed, they are removed — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

sdetweil · 2020-01-01T16:05:10Z

Another user reported that install failed to install the helper file. Which means it was cloned and then erased on npm install https://forum.magicmirror.builders/topic/11883/black-screen-on-startup

…

On Wed, Jan 1, 2020, 10:02 AM Michael Teeuw ***@***.***> wrote: Will look into it. Hope I can fix it before release. Vriendelijke groeten, Michael Teeuw --- Sent from my iPhone. Michael Teeuw Xonay Media www.xonaymedia.nl 06 51 71 36 15 > Op 1 jan. 2020 om 16:43 heeft sam detweiler ***@***.***> het volgende geschreven: > > > I think the helper being erased is a big problem. I think it is a security fix that is erasing. If modules not listed but installed, they are removed > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub, or unsubscribe. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1849>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALNYHR32DGFKCUXLRCBJLTQ3S5ATANCNFSM4KBXUVLQ> .

MichMich · 2020-01-01T16:44:22Z

Reading that, I’m not confident it was caused by an NPM install. At at least not an non install ran in the correct folder. But non the less I will try to look for a solution. First priority is to get Travis to work again.

sdetweil · 2020-01-01T17:36:40Z

Ok. I am for stable system. Test system later. The vendor stuff has been failing for quite a while now. Only the weather tests are affected so far by the node_helper.

…

On Wed, Jan 1, 2020, 10:44 AM Michael Teeuw ***@***.***> wrote: Reading that, I’m not confident it was caused by an NPM install. At at least not an non install ran in the correct folder. But non the less I will try to look for a solution. First priority is to get Travis to work again. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1849>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALNYHSKAIAVDVWV6UC35ULQ3TB6PANCNFSM4KBXUVLQ> .

sdetweil · 2020-01-01T17:37:37Z

We have a whole quarter to solve the Travis problems

…

On Wed, Jan 1, 2020, 10:44 AM Michael Teeuw ***@***.***> wrote: Reading that, I’m not confident it was caused by an NPM install. At at least not an non install ran in the correct folder. But non the less I will try to look for a solution. First priority is to get Travis to work again. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1849>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALNYHSKAIAVDVWV6UC35ULQ3TB6PANCNFSM4KBXUVLQ> .

MichMich · 2020-01-01T17:57:58Z

I can't release without Travis. Releases are blocked. And for a good reason. Will work on a solution now.

MichMich · 2020-01-01T19:21:12Z

@sdetweil the node helper is no longer part op de node_modules folder. Now looking for the weather tests fails.

roramirez · 2020-01-01T22:55:04Z

I think the helper being erased is a big problem. I think it is a security fix that is erasing. If modules not listed but installed, they are removed

I can understand why will be the better if we has a node helper in external repository and what kind of issue could fix include in this way. We should keep this code in main code of project, its to more easy maintent this code in this repo.

sdetweil · 2020-01-01T23:06:45Z

I asked multiple times for Mich to create the repo on his GitHub, but got no action. So I created it on mine.

Mich is welcome to move it to his.
I am trying to stop user acceptance problems

MichMich · 2020-01-01T23:09:28Z

This is already fixed. The node helper is already outside the modules folder (in /js to be exactly). It is aliased so you can just use the same require statement. (Non breaking).

I want to keep everything in one repo to keep it simple. This accomplishes that.

sdetweil · 2020-01-01T23:10:31Z

As for the Travis problem there are electron version dependencies on some of the libraries used by the test cases. Spectron, for example.
I updated that one to match the electron version.
Don't know if there are other lib problems too.

Tests run locally after install work great.(weather works, vendor still fails, but still reports ok)
So how do we get those libs updated in Travis environment?

There is no change mgmt guidance for the Travis tests

sdetweil · 2020-01-01T23:13:11Z

Helper in js. good! I didn't see that as a possibility.
The alias, will have to see how u did that

roramirez · 2020-01-01T23:26:59Z

As for the Travis problem there are electron version dependencies on some of the libraries used by the test cases. Spectron, for example.
I updated that one to match the electron version.
Don't know if there are other lib problems too.

Tests run locally after install work great.(weather works, vendor still fails, but still reports ok)
So how do we get those libs updated in Travis environment?

There is no change mgmt guidance for the Travis tests

What O.S, npm and node versions are you using?

Could you paste here the package.json in your local environment?

Also, npm list

sdetweil · 2020-01-01T23:50:35Z

Will do.
node -v = v10.18.0
npm -v =6.13.4
Tried on raspian, Ubuntu,

All tests fail on macOs Catalina. 10.15.2

I am away for most of the rest of the day
I posted a new package-lock with this pr. which solved the problem originally (Travis went from failing to passing)

I did a clone, checkout for develop, npm install, then ran two testcase sets

npm list
package.json
package-lock.json

lsb_release -a

No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 18.04.3 LTS
Release: 18.04
Codename: bionic

sdetweil · 2020-01-02T04:54:24Z

looks like the screen setup for travis has changed

https://electronjs.org/docs/tutorial/testing-on-headless-ci

when I do export DISPLAY=:0
and then run the npm run test:e2e (locally) it works
but not the vendor tests..

the vendor tests are because the port didn't get set when using the js/electron.js launch
I added debug to the vendor_spec.js and here is the output of the before, launching js/electron.js
the port is not set

Vendors
starting js/electron
electron path=/home/sam/MagicMirror/node_modules/.bin/electron
new electron app =[object Object]
parms={"host":"127.0.0.1","port":9515,"quitTimeout":1000,"startTimeout":5000,"waitTimeout":5000,"connectionRetryCount":10,"connectionRetryTimeout":30000,"nodePath":"/usr/bin/node","path":"/home/sam/MagicMirror/node_modules/.bin/electron","args":["/home/sam/MagicMirror/tests/e2e/../../js/electron.js"],"chromeDriverArgs":[],"env":{},"workingDirectory":"/home/sam/MagicMirror","webdriverOptions":{},"requireName":"require"}

if I change the get urls to the 9515 port, the it works..

this didn't work (tests/e2e/from vendor_spec.js)
describe("Get list vendors", function () {

	before(function () {
		process.env.MM_CONFIG_FILE = "tests/configs/env.js";  // < ----
	});

that before() is never called.
and if u move the process.env. to before the app.start() it doesn't work there either..

sdetweil · 2020-01-02T13:52:57Z

the untouched e2e test also works on macOS catalina after doing export DISPLAY=:0
i had to change the address for the vedor tests to port 9515, but it worked then

roramirez added 3 commits December 31, 2019 19:31

Revert "stop helper class being erased"

7e2c786

This reverts commit 2fbedca.

Update package-lock*

905d0ca

Update changelog for revert commit

3a42663

This was referenced Dec 31, 2019

Base translations have fallen behind newer versions (e2e test) #1843

Closed

Very minor README spelling error fix #1844

Merged

Issues with Weather Tests. - Tests currently disabled. #1840

Closed

MichMich merged commit d2b30b4 into MagicMirrorOrg:develop Jan 1, 2020

roramirez deleted the fix-ci branch January 20, 2020 22:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix CI #1849

Fix CI #1849

roramirez commented Dec 31, 2019

sdetweil commented Dec 31, 2019 •

edited

Loading

sdetweil commented Dec 31, 2019

MichMich commented Jan 1, 2020

sdetweil commented Jan 1, 2020

MichMich commented Jan 1, 2020

sdetweil commented Jan 1, 2020

MichMich commented Jan 1, 2020 via email

sdetweil commented Jan 1, 2020 via email

MichMich commented Jan 1, 2020

sdetweil commented Jan 1, 2020 via email

sdetweil commented Jan 1, 2020 via email

MichMich commented Jan 1, 2020 •

edited

Loading

MichMich commented Jan 1, 2020

roramirez commented Jan 1, 2020

sdetweil commented Jan 1, 2020 •

edited

Loading

MichMich commented Jan 1, 2020

sdetweil commented Jan 1, 2020 •

edited

Loading

sdetweil commented Jan 1, 2020 •

edited

Loading

roramirez commented Jan 1, 2020

sdetweil commented Jan 1, 2020 •

edited

Loading

sdetweil commented Jan 2, 2020

sdetweil commented Jan 2, 2020

Fix CI #1849

Fix CI #1849

Conversation

roramirez commented Dec 31, 2019

sdetweil commented Dec 31, 2019 • edited Loading

sdetweil commented Dec 31, 2019

MichMich commented Jan 1, 2020

sdetweil commented Jan 1, 2020

MichMich commented Jan 1, 2020

sdetweil commented Jan 1, 2020

MichMich commented Jan 1, 2020 via email

sdetweil commented Jan 1, 2020 via email

MichMich commented Jan 1, 2020

sdetweil commented Jan 1, 2020 via email

sdetweil commented Jan 1, 2020 via email

MichMich commented Jan 1, 2020 • edited Loading

MichMich commented Jan 1, 2020

roramirez commented Jan 1, 2020

sdetweil commented Jan 1, 2020 • edited Loading

MichMich commented Jan 1, 2020

sdetweil commented Jan 1, 2020 • edited Loading

sdetweil commented Jan 1, 2020 • edited Loading

roramirez commented Jan 1, 2020

sdetweil commented Jan 1, 2020 • edited Loading

sdetweil commented Jan 2, 2020

sdetweil commented Jan 2, 2020

sdetweil commented Dec 31, 2019 •

edited

Loading

MichMich commented Jan 1, 2020 •

edited

Loading

sdetweil commented Jan 1, 2020 •

edited

Loading

sdetweil commented Jan 1, 2020 •

edited

Loading

sdetweil commented Jan 1, 2020 •

edited

Loading

sdetweil commented Jan 1, 2020 •

edited

Loading