1840 fix weather tests #1927
Merged
1840 fix weather tests #1927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
|
Also I enabled the tests for always the latest stable and long term support version of nodejs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1840
Fix timing issue in weather tests => returning response by url instead of index
By debugging the tests locally I noticed, that the tests were failing randomly. By taking a closer look I spotted that the failing tests rendered the weather data as JSON in the spectron window. Increasing the timeouts helped me to detect in the network console that the weather data was retunred for the request to the nunjuck template. It seemed that in some random cases there was a timing issue, which requested first the template and then the weather.
The following change is resolving the timing issue, as it is returning the data based on the url, rather than relying on a specific order of requests.