Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step to use electron only when needed in the tests, see #2408.
The idea comes from @fewieden see this comment.
All tests using node-fetch and the translations test can run in server-only-mode instead using electron. So I make them work for this and moved all the remaining electron tests to a new category
electron
(frome2e
) hoping we can shift more electron tests toe2e
in the future.I also changed
logger.js
again to be silent in the tests.Tested all changes running mm in server-only mode and running with electron on a pi3.
Some dependencies were updated too.