Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test setup #2664

Merged
merged 7 commits into from
Sep 28, 2021
Merged

Test setup #2664

merged 7 commits into from
Sep 28, 2021

Conversation

khassel
Copy link
Collaborator

@khassel khassel commented Sep 17, 2021

This is a first step to use electron only when needed in the tests, see #2408.
The idea comes from @fewieden see this comment.

All tests using node-fetch and the translations test can run in server-only-mode instead using electron. So I make them work for this and moved all the remaining electron tests to a new category electron (from e2e) hoping we can shift more electron tests to e2e in the future.

I also changed logger.js again to be silent in the tests.

Tested all changes running mm in server-only mode and running with electron on a pi3.

Some dependencies were updated too.

@codecov-commenter
Copy link

Codecov Report

Merging #2664 (c3c5307) into develop (60e0377) will decrease coverage by 1.06%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2664      +/-   ##
===========================================
- Coverage    71.01%   69.94%   -1.07%     
===========================================
  Files           17       17              
  Lines          890      895       +5     
===========================================
- Hits           632      626       -6     
- Misses         258      269      +11     
Impacted Files Coverage Δ
js/logger.js 50.00% <30.00%> (-35.72%) ⬇️
js/app.js 69.74% <100.00%> (-0.60%) ⬇️
js/server.js 85.10% <100.00%> (-6.01%) ⬇️
js/defaults.js 85.71% <0.00%> (-14.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60e0377...c3c5307. Read the comment docs.

@MichMich MichMich merged commit e10f620 into MagicMirrorOrg:develop Sep 28, 2021
@khassel khassel deleted the test-setup branch October 4, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants