-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update scripts to run under windows #2698
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2698 +/- ##
========================================
Coverage 61.83% 61.83%
========================================
Files 8 8
Lines 262 262
========================================
Hits 162 162
Misses 100 100 Continue to review full report at Codecov.
|
no idea at the moment, can't reproduce it in my environment, it happens only in the ci jobs ... Alert could also be related to the refactor of this module ... |
will increase the testTimeout to see if this solves the problem ... |
is install fixed? vendor and fonts do not get installed as the script is wrong for windows batch |
if we went back to a script for start, then there could be two scripts then launch would the |
Argh, you're right @sdetweil windows-npm-install doesnt traverse into the font/vendor dirctories. Having scripts seems like the only viable solution. But I am not sure if @MichMich wants more files in the repo. But it would help for those who would want to develop on windows. So, he might say yes or no ;-) ? |
If @MichMich `s decision is to merge this, we should also update the documentation. AFAIS there is no word about windows in the docs, so it should may mentioned here and also here. May there are other places but searching does not work at the moment. Tests are failing here due to: npm ERR! code EBADPLATFORM
npm ERR! notsup Unsupported platform for fsevents@2.3.2: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm ERR! notsup Valid OS: darwin
npm ERR! notsup Valid Arch: any
npm ERR! notsup Actual OS: linux
npm ERR! notsup Actual Arch: x64 |
Oh, this isnt ready to be merged with the windows install being not proper. Will convert it into a draft until we know how to proceed. |
I'm a bit conflicted with this PR. A while ago we made the decision to remove any non Raspberry support because it is simply not maintainable. The problem of adding these features is that people will rely on them and expect from us we make sure it keeps working. I personally have no interest or intention to maintain any windows support. Since this PR does mainly add some convenience helpers it might be a better option to just add info to the docs. What do you guys think? |
+1 new dependency
I would have no problem with adding this so far but adding additional |
Funny, I looked in the docs and found something regarding this already in there: https://docs.magicmirror.builders/getting-started/installation.html#common-installation-issues Maybe this section needs to be clearer about why it is there (non.raspberry installation)? |
Created a PR in the MM Docs repo. Maybe that might help? |
but the doc IMPLIES that you SUPPORT running on Windows, which you "don't", so I would remove the doc too .. you have to make up your mind. |
I didnt thought about that since stuff about other (not officially supported) installation methods is in the docs too |
yes, I saw this section and obviously the windows workaround is described there but windows is not mentioned ... |
I think the best thing is to close this issue and to improve the docs. I've applied for Agolia DocSearch to make searching the docs better. |
Closing in favor of MagicMirrorOrg/MagicMirror-Documentation#92 |
Some people want to run MM under windows, so this PR adds a new start script entry without the display stuff.
It also makes the tests runnable under windows thanks to the cross-env library.