Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace spectron with playwright, update dependencies including electron update to v16 #2715

Merged
merged 3 commits into from
Nov 28, 2021

Conversation

khassel
Copy link
Collaborator

@khassel khassel commented Nov 27, 2021

Changes:

@khassel
Copy link
Collaborator Author

khassel commented Nov 27, 2021

tests are failing because github is partially down, will wait until tomorrow and trigger them again ...

@codecov-commenter
Copy link

Codecov Report

Merging #2715 (f6f3aa1) into develop (2b87d6e) will increase coverage by 7.63%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2715      +/-   ##
===========================================
+ Coverage    61.83%   69.46%   +7.63%     
===========================================
  Files            8        8              
  Lines          262      262              
===========================================
+ Hits           162      182      +20     
+ Misses         100       80      -20     
Impacted Files Coverage Δ
js/server.js 87.03% <0.00%> (+1.85%) ⬆️
js/app.js 59.66% <0.00%> (+15.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b87d6e...f6f3aa1. Read the comment docs.

@MichMich MichMich merged commit 559970c into MagicMirrorOrg:develop Nov 28, 2021
@MichMich
Copy link
Collaborator

Hero! Thank you very much!

@khassel khassel deleted the playwright branch November 28, 2021 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants