Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yr provider to new api #3197

Merged
merged 4 commits into from
Sep 20, 2023
Merged

Conversation

martingron
Copy link
Contributor

@martingron martingron commented Sep 15, 2023

Some changes after yr api was deprecated and replaced with a new one.

Fixes #3189

package.json Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2023

Codecov Report

Merging #3197 (4f6cf46) into develop (e87f50e) will decrease coverage by 0.26%.
Report is 159 commits behind head on develop.
The diff coverage is 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop    #3197      +/-   ##
===========================================
- Coverage    25.56%   25.30%   -0.26%     
===========================================
  Files           53       54       +1     
  Lines        11481    11922     +441     
===========================================
+ Hits          2935     3017      +82     
- Misses        8546     8905     +359     
Files Changed Coverage Δ
modules/default/weather/providers/yr.js 0.00% <0.00%> (ø)

... and 21 files with indirect coverage changes

Copy link
Collaborator

@rejas rejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, will check once I am back at a pc later today's

@rejas
Copy link
Collaborator

rejas commented Sep 15, 2023

One mall thing: run the linting task over the files and commit again.

@martingron
Copy link
Contributor Author

linting task?

@rejas
Copy link
Collaborator

rejas commented Sep 15, 2023

Npm run lint:prettier

@rejas rejas changed the title Fixes #3189 New api from yr Update yr provider to new api Sep 15, 2023
Copy link
Collaborator

@rejas rejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run npm run lint:prettier and commit the changes

@rejas rejas merged commit 8b1c279 into MagicMirrorOrg:develop Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants