Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix electron tests mocking dates #3599

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Conversation

khassel
Copy link
Collaborator

@khassel khassel commented Oct 24, 2024

fixes #3597

Changes:

  • electron tests: add mocking to electron.js for mocking the server side, before only the browser side was mocked
  • publish "/tests/configs" and "/tests/mocks" always in server.js, this reverts a change done with latest release, we need this for debugging (otherwise you get on the screen that your config has errors but config check is successful ...)
  • revert hotfix in tests/configs/modules/calendar/show-duplicates-in-calendar.js
  • fix tests/configs/modules/calendar/custom.js to allow events in the past (I don't know how this could work before when testing css classes yesterday and dayBeforeYesterday --> it worked before because the server side did not mock and therefore was not in the past)

@khassel khassel requested a review from rejas October 24, 2024 22:09
Copy link
Collaborator

@sdetweil sdetweil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, so net have the electron process set the date for the test run, helper just passes it on thru env. cool

@rejas rejas merged commit cfa5c0d into MagicMirrorOrg:develop Oct 25, 2024
10 checks passed
@khassel khassel deleted the electron branch October 25, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants