Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection methods in pool #39

Closed
imbolc opened this issue Oct 30, 2016 · 2 comments
Closed

Connection methods in pool #39

imbolc opened this issue Oct 30, 2016 · 2 comments
Labels
enhancement feedback

Comments

@imbolc
Copy link

imbolc commented Oct 30, 2016

I think it would be convenient to have connection execute and fetch.. methods in pool. Because single queries is not so rare. I mean:

async with pool.acquire() as con:
    await con.fetch('SELECT ...')

Would be just:

await pool.fetch('SELECT ...')

I can make PR if you like it.
@1st1 1st1 added the feedback label Nov 14, 2016
@1st1
Copy link
Member

1st1 commented Nov 14, 2016

This seems like a nice idea, we'll think about it.

@cctse
Copy link

cctse commented Feb 16, 2017

hope this will coming soon, as asyncio-redis pool does

1st1 added a commit that referenced this issue Mar 31, 2017
@1st1
Expose some of Connection methods directly on the Pool object.
0119301 
Specifically Pool now implements the following methods:

 * Pool.execute()
 * Pool.executemany()
 * Pool.fetch()
 * Pool.fetchrow()
 * Pool.fetchval()

Fixes issue #39.
1st1 added a commit that referenced this issue Mar 31, 2017
@1st1
Expose some of Connection methods directly on the Pool object.
12f8761 
Specifically Pool now implements the following methods:

 * Pool.execute()
 * Pool.executemany()
 * Pool.fetch()
 * Pool.fetchrow()
 * Pool.fetchval()

Fixes: #39.
1st1 added a commit that referenced this issue Mar 31, 2017
@1st1
Expose some of Connection methods directly on the Pool object.
daa483c 
Specifically Pool now implements the following methods:

 * Pool.execute()
 * Pool.executemany()
 * Pool.fetch()
 * Pool.fetchrow()
 * Pool.fetchval()

Fixes: #39.
@1st1 1st1 closed this as completed in 1b3a847 Mar 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement feedback
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@1st1 @imbolc @cctse