Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected behavior when connecting to database -> Database username is used as database name. #823

Closed
KharchenkoDmitriy opened this issue Sep 6, 2021 · 1 comment · Fixed by #847
Closed

Unexpected behavior when connecting to database -> Database username is used as database name. #823

KharchenkoDmitriy opened this issue Sep 6, 2021 · 1 comment · Fixed by #847

Comments

@KharchenkoDmitriy
Copy link

KharchenkoDmitriy commented Sep 6, 2021 •
edited
Loading

asyncpg/asyncpg/connect_utils.py

Line 390 in 36658fa

database = user

In documentation it is said:

If not specified, the value parsed from the dsn argument is used, or the value of the PGDATABASE environment variable, or the operating system name of the user running the application.

But in fact if database username is provided but database is not, database user name is used instead of system username.

Also why not just use postgres as default value instead of username?

asyncpg version ==0.24.0
postgres: docker image postgres:13-alpine, at the moment it use version 13.4
python version ==3.8
@elprans
Copy link
Member

elprans commented Nov 7, 2021

Yes, the docs are slightly incorrect, I'll make an edit.

Also why not just use postgres as default value instead of username?

For compatibility, asyncpg follows the behavior of libpq which underpins most other PostgreSQL bindings.

elprans added a commit that referenced this issue Nov 7, 2021
@elprans
Fix the description of the database argument to connect()
327b7d2 
The docs incorrectly claim that the `database` argument defaults to
the OS username, whereas in fact, the computed value of the `user`
argument is used.

Fixes: #823.
@elprans elprans mentioned this issue Nov 7, 2021
Merged
elprans added a commit that referenced this issue Nov 16, 2021
@elprans
Fix the description of the database argument to connect() (#847)
a2a9237 
The docs incorrectly claim that the `database` argument defaults to
the OS username, whereas in fact, the computed value of the `user`
argument is used.

Fixes: #823.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the description of the database argument to connect() MagicStack/asyncpg
2 participants
@elprans @KharchenkoDmitriy