Use the general statement cache for type introspection #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1st1
reviewed
Sep 27, 2017
asyncpg/connection.py
Outdated
| @@ -1215,6 +1204,13 @@ def _drop_global_statement_cache(self): | |||
| with self._stmt_exclusive_section: | |||
| return await self._do_execute(query, executor, timeout) | |||
There was a problem hiding this comment.
Maybe we should refactor def _execute to:
async def _execute(self, query, args, limit, timeout, return_status=False):
with self._stmt_exclusive_section:
return await self.__execute(self, query, args, limit, timeout, return_status)?
1st1
reviewed
Sep 27, 2017
asyncpg/connection.py
Outdated
| # cache turned off has blown away the anonymous statement | ||
| # we've prepared for the query, so we need to re-prepare it. | ||
| statement = await self._protocol.prepare( | ||
| stmt_name, query, timeout) |
There was a problem hiding this comment.
Yes, and my code is wrong.
There was a problem hiding this comment.
Pushed a more robust check.
elprans
force-pushed
the
no-cache-introspection
branch
from
a6d08db
to
dccb430
Compare
1st1
reviewed
Sep 28, 2017
| self._protocol.get_settings().register_data_types(types) | ||
| if not intro_stmt.name and not statement.name: |
There was a problem hiding this comment.
Just check for statement.name? The current check won’t work correctly if statement is anonymous and intro_stmt is not. Also, tests?
There was a problem hiding this comment.
I don't think that's true. From the docs:
An unnamed prepared statement lasts only until the next Parse statement specifying the unnamed statement as destination is issued.
I added another test to show that.
1st1
approved these changes
Sep 28, 2017
Type introspection queries now rely on the general statement cache instead of ad-hoc prepared statements. Fixes: #198.
elprans
force-pushed
the
no-cache-introspection
branch
from
b1edeea
to
f774cbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type introspection queries now rely on the general statement cache
instead of ad-hoc prepared statements.
Fixes: #198.