Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage documentation for hstore #515

Merged
merged 2 commits into from
Jul 19, 2020

Conversation

aaliddell
Copy link
Contributor

Previously the usage documentation suggested that the integer values in the hstore values would be converted from strings into ints. This is not the case, as all values are returned as string or None: https://github.com/MagicStack/py-pgproto/blob/e9391d4c8615c73291bc2fc77a3e6efb484bcbd0/codecs/hstore.pyx#L66-L69

@aaliddell
Copy link
Contributor Author

The failed test in this PR appears to be unrelated to the changes made, since only one RST file was touched.

Copy link
Member

@elprans elprans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@elprans elprans merged commit 39040b3 into MagicStack:master Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants