Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add query logging #630

Closed
wants to merge 23 commits into from
Closed

Add query logging #630

wants to merge 23 commits into from

Conversation

dmig-alarstudios
Copy link

Implement the #629

HarrySky
HarrySky reviewed Oct 2, 2020
View reviewed changes
Copy link

@HarrySky HarrySky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a question and suggestion to document the "magic number" 5

asyncpg/connection.py Show resolved Hide resolved
dmig and others added 8 commits January 27, 2021 17:12
@dmig
move connect_kwargs description to the place it's expected to be
2b34cb9
@dmig
declare query_logging explicitly in create_pool()
670d505
@dmig
add documentation section about query logging
c15d62a
@kitogo @dmig
Avoid unnecessary overhead during connection reset (MagicStack#648)
102aa23 
UNLISTEN is now available in Hot Standby mode in all supported
PostgreSQL versions, therefore there's no reason anymore to wrap
it in DO block. This should significantly speed up connection reset.
@timgates42 @dmig
docs: fix simple typo, verifiction -> verification (MagicStack#682)
1089e49 
There is a small typo in asyncpg/connection.py.

Should read `verification` rather than `verifiction`.
@elprans @dmig
Don't build aarch64 wheels for now
f5484b2 
The porting of arm64 builds to Github Actions uncovered an
architecture-specific (or, perhaps, virtualization-specific) bug in
asyncpg, so, rather than blocking the release, drop aarch64 wheels for
now.  Also, `manylinux2014_aarch64` is not considered stable yet
(see pypa/manylinux#84) and so the compiled wheels might not even work
correctly on all aarch64 boxes.
@elprans @dmig
asyncpg v0.22.0
3e392d5 
A new asyncpg release is here.

Notable additions include Python 3.9 support, support for recently added
PostgreSQL types like `jsonpath`, and last but not least, vastly
improved `executemany()` performance.  Importantly, `executemany()` is
also now _atomic_, which means that either all iterations succeed, or
none at all, whereas previously partial results would have remained in
place, unless `executemany()` was called in a transaction.

There is also the usual assortment of improvements and bugfixes, see the
details below.

This is the last release of asyncpg that supports Python 3.5, which has
reached EOL last September.

Improvements
------------

* Vastly speedup executemany by batching protocol messages (MagicStack#295)
  (by @fantix in 690048d for MagicStack#295)

* Allow using custom `Record` class
  (by @elprans in db4f1a6 for MagicStack#577)

* Add Python 3.9 support (MagicStack#610)
  (by @elprans in c05d726 for MagicStack#610)

* Prefer SSL connections by default (MagicStack#660)
  (by @elprans in 16183aa for MagicStack#660)

* Add codecs for a bunch of new builtin types (MagicStack#665)
  (by @elprans in b53f038 for MagicStack#665)

* Expose Pool as `asyncpg.Pool` (MagicStack#669)
  (by @rugleb in 0e0eb8d for MagicStack#669)

* Avoid unnecessary overhead during connection reset (MagicStack#648)
  (by @kitogo in ff5da5f for MagicStack#648)

Fixes
-----

* Add a workaround for bpo-37658
  (by @elprans in 2bac166 for #21894)

* Fix wrong default transaction isolation level (MagicStack#622)
  (by @fantix in 4a627d5 for MagicStack#622)

* Fix `set_type_codec()` to accept standard SQL type names (MagicStack#619)
  (by @elprans in 68b40cb for MagicStack#619)

* Ignore custom data codec for internal introspection (MagicStack#618)
  (by @fantix in e064f59 for MagicStack#618)

* Fix null/NULL quoting in array text encoder (MagicStack#627)
  (by @fantix in 92aa806 for MagicStack#627)

* Fix link in connect docstring (MagicStack#653)
  (by @samuelcolvin in 8b313bd for MagicStack#653)

* Make asyncpg work with pyinstaller (MagicStack#651)
  (by @Atem18 in 5ddabb1 for MagicStack#651)

* Fix possible `AttributeError` exception in `ConnectionSettings` (MagicStack#632)
  (by @petriborg in 0d23182 for MagicStack#632)

* Prohibit custom codecs on domains
  (by @elprans in 50f964f for MagicStack#457)

* Raise proper error on anonymous composite input (tuple arguments) (MagicStack#664)
  (by @elprans in 7252dbe for MagicStack#664)

* Fix incorrect application of custom codecs in some cases (MagicStack#662)
  (by @elprans in 50f65fb for MagicStack#662)
@elprans @dmig
Post-release version bump
4319d57
@dmig-alarstudios
Copy link
Author

Any idea what's failing in validate-release-request ?

@dmig-alarstudios
Copy link
Author

@HarrySky could you review, please?

@HarrySky
Copy link

LGTM, if those if _query_logger: checks does not impact performance much, but I am not a maintainer, you can try to ping 1st1 and elprans 😃

@dmig-alarstudios
Copy link
Author

@1st1, @elprans, what'd be your word?

@conao3
Copy link

conao3 commented Aug 16, 2021

+1. Any news on this PR?

@maksimartemevalar
Copy link

any updates guys? :)

@dcwatson dcwatson mentioned this pull request Jun 30, 2023
Merged
@elprans
Copy link
Member

elprans commented Oct 9, 2023

Structured query logging was added in #1043.

@elprans elprans closed this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarrySky HarrySky HarrySky left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@dmig-alarstudios @HarrySky @conao3 @maksimartemevalar @elprans @dmig @kitogo @timgates42